Bug 87006

Summary: Plugin, Fits, and Filter dialogs resize for each plugin
Product: [Applications] kst Reporter: Rick Chern <rchern>
Component: generalAssignee: George Staikos <staikos>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 1.x   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Rick Chern 2004-08-12 00:26:16 UTC 
Version:           0.99-devel (using KDE KDE 3.2.1)
Installed from:    Compiled From Sources
Compiler:          gcc (GCC) 3.3.2 20031022  
OS:                Linux

The fit dialogs has strangely arranged text fields, and both the fit and filter dialogs and be resized smaller than they should be.

How to reproduce:
- start Kst
- create a plot and curves, and right-click->Fit..

The text fields do not extend to the right of the dialog, and the bottom field is cut off (for Fit Exponential).  There is also extraneous space.

- resize the dialog

The dialog can be resized too small.

The filter dialog can be resized too small as well.
Comment 1 George Staikos 2004-08-12 00:36:26 UTC 
Actually many of our dialogs have geometry issues.
Comment 2 Rick Chern 2004-08-16 20:42:35 UTC 
Increasing the scope of this wish:

Currently the plugin, fit, and filter dialogs resize when the selected plugin is changed.  Not only do they resize vertically, but horizontally as well.  This can be a bit disconcerting.  

It would be nice if the dialogs did not resize at all.  Perhaps the list of inputs could be put in a list box (using a custom QListBoxItem), with the list box having two columns - one with the name of the input, and one with lineedits/comboboxes to select the input.  If the list becomes long, the list box would have a scroll bar. The same thing would be done with outputs, in a list box below.
Comment 3 George Staikos 2004-08-16 21:39:11 UTC 
I don't like this behaviour.  I much prefer resizing the dialog since we seem to always have a number of inputs and outputs small enough to make this sane, and scrollbars with more widgets seem to be a bit more confusing.  By the way, the solution to this style of UI would be to use a scrollview with widgets inside it.
Comment 4 Rick Chern 2004-08-17 19:50:44 UTC 
I think for most of the plugins, resizing is fine, but on Andrew's laptop, there is one existing plugin that resizes the dialog so that the OK and Cancel buttons go off the screen.
Comment 5 George Staikos 2004-10-19 08:08:22 UTC 
Working on this one in conjunction with #85676
Comment 6 George Staikos 2004-10-19 16:06:08 UTC 
CVS commit by staikos: 

Don't let the plugin dialog be resized smaller than the contents
BUG: 87006


  M +1 -0      kstfilterdialog_i.cpp   1.20
  M +1 -0      kstfitdialog_i.cpp   1.43
  M +1 -0      kstplugindialog_i.cpp   1.91


--- kdeextragear-2/kst/kst/kstfilterdialog_i.cpp  #1.19:1.20
@@ -165,4 +165,5 @@ void KstFilterDialogI::fixupLayout() {
   _pluginFrame->resize(_pluginFrame->sizeHint());
   resize(sizeHint());
+  setMinimumSize(size());
   updateGeometry();
 }

--- kdeextragear-2/kst/kst/kstfitdialog_i.cpp  #1.42:1.43
@@ -178,4 +178,5 @@ void KstFitDialogI::fixupLayout() {
   _pluginFrame->resize(_pluginFrame->sizeHint());
   resize(sizeHint());
+  setMinimumSize(size());
   updateGeometry();
 }

--- kdeextragear-2/kst/kst/kstplugindialog_i.cpp  #1.90:1.91
@@ -267,4 +267,5 @@ void KstPluginDialogI::fixupLayout() {
   _pluginFrame->resize(_pluginFrame->sizeHint());
   resize(sizeHint());
+  setMinimumSize(size());
   updateGeometry();
 }