Summary: | [test case] crash in khtml::renderBlock::makeChildrenNonInline on immonet.de | ||
---|---|---|---|
Product: | [Applications] konqueror | Reporter: | Oswald Buddenhagen <ossi> |
Component: | khtml renderer | Assignee: | Konqueror Developers <konq-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | kde-bugs, s.carstens |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: | testcase attached |
Description
Oswald Buddenhagen
2004-08-11 13:52:04 UTC
Hmm, no bang for me. Crashes here as well cvs HEAD from 2 or 3 days Using host libthread_db library "/lib/libthread_db.so.1". [KCrash handler] #34 0x414f71b1 in kill () from /lib/libc.so.6 #35 0x4138a9c1 in pthread_kill () from /lib/libpthread.so.0 #36 0x4138accb in raise () from /lib/libpthread.so.0 #37 0x414f6df4 in raise () from /lib/libc.so.6 #38 0x414f85a8 in abort () from /lib/libc.so.6 #39 0x414f056c in __assert_fail () from /lib/libc.so.6 #40 0x415f6ee0 in _IO_2_1_stdout_ () from /lib/libc.so.6 #41 0xbffff7e0 in ?? () #42 0x415effe6 in in6addr_loopback () from /lib/libc.so.6 #43 0x424e03e0 in khtml::RenderBlock::calcMinMaxWidth()::__PRETTY_FUNCTION__ () from /home/gdcb04/kde-cvs/lib/libkhtml.so.4 #44 0x00000125 in ?? () #45 0x424e0140 in khtml::RenderBlock::addChildToFlow(khtml::RenderObject*, khtml::RenderObject*)::__PRETTY_FUNCTION__ () from /home/gdcb04/kde-cvs/lib/libkhtml.so.4 #46 0x415effe6 in in6addr_loopback () from /lib/libc.so.6 #47 0x424e04a0 in khtml::RenderBlock::calcMinMaxWidth()::__PRETTY_FUNCTION__ () from /home/gdcb04/kde-cvs/lib/libkhtml.so.4 #48 0xffffffff in ?? () #49 0x087210d8 in ?? () #50 0x086e6880 in ?? () #51 0x42555728 in __JCR_LIST__ () from /home/gdcb04/kde-cvs/lib/libkhtml.so.4 #52 0x08780770 in ?? () #53 0xbfffd608 in ?? () #54 0x4238edab in khtml::RenderBlock::makeChildrenNonInline (this=0x620032, insertionPoint=0x72657571) at /home/gdcb04/src/kde/kdelibs/khtml/rendering/render_block.cpp:325 And you would think that developers are able to file to the right component? :-) *** Bug 92726 has been marked as a duplicate of this bug. *** Created attachment 8177 [details]
testcase attached
Testcase from #92726
*** Bug 93573 has been marked as a duplicate of this bug. *** I think the crash happens because the container is inline, but gets a tries to noninline its children. CVS commit by ggarand: fix crashes for fancy body displays BUG: 86973, 98975 M +5 -1 html_baseimpl.cpp 1.204 --- kdelibs/khtml/html/html_baseimpl.cpp #1.203:1.204 @@ -207,5 +207,9 @@ void HTMLBodyElementImpl::attach() style->ref(); if (parentNode()->renderer() && style->display() != NONE) { + if (style->display() == BLOCK) + // only use the quirky class for block display m_render = new (getDocument()->renderArena()) RenderBody(this); + else + m_render = RenderObject::createObject(this, style); m_render->setStyle(style); parentNode()->renderer()->addChild(m_render, nextRenderer()); CVS commit by ggarand: backport crash fix CCBUG: 86973, 98975 M +5 -1 html_baseimpl.cpp 1.203.2.1 --- kdelibs/khtml/html/html_baseimpl.cpp #1.203:1.203.2.1 @@ -207,5 +207,9 @@ void HTMLBodyElementImpl::attach() style->ref(); if (parentNode()->renderer() && style->display() != NONE) { + if (style->display() == BLOCK) + // only use the quirky class for block display m_render = new (getDocument()->renderArena()) RenderBody(this); + else + m_render = RenderObject::createObject(this, style); m_render->setStyle(style); parentNode()->renderer()->addChild(m_render, nextRenderer()); |