Bug 86748

Summary: [Patch] Linked views should be in the same tab
Product: [Applications] konqueror Reporter: Albert Cervera Areny <albert>
Component: tabbingAssignee: Konqueror Developers <konq-bugs>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: Make linked views follow only if are in the same tab of the sender

Description Albert Cervera Areny 2004-08-07 12:00:35 UTC 
Version:            (using KDE KDE 3.2.92)
Installed from:    Compiled From Sources
OS:                Linux

With previous versions of Konqueror I used to have two tabs. One for Qt documentation and another one for KDE. Each tab was split in two linked views. So when you clicked in a class from the Qt doc the class showed in the second view of that tab. While the other two views of the other tab remained the same. From KDE 3.3, when you click on the linked view of one tab the non-locked view of the other tab ALSO follows the link, so you have that Qt class opened in both tabs.

I suppose this is not intended, at least, I can't see very much of its use. I've tried to solve this myself but haven't been able to ensure the sender and linked views where on the same tab in KonqMainWindow::makeViewsFollow. I'll keep on trying, and see how the frame/view hierarchy works...
Comment 1 Stephan Binner 2004-08-07 19:33:39 UTC 
Related to 86562?
Comment 2 Albert Cervera Areny 2004-08-12 01:32:12 UTC 
It seems it's not related. I've tried cvs konqueror and the problem persists. In that case the views where not linked.

Here the problem is with linked views in makeViewsFollow function no test is done to ensure that the linked view that we make follow is in the same tab of the sender view. This makes impossible to have two linked views in one tab and two linked views in another tab and both pairs independent of each other.

Hope that now the problem is a bit more clear.
Comment 3 Albert Cervera Areny 2004-08-14 17:55:06 UTC 
Created attachment 7107 [details]
Make linked views follow only if are in the same tab of the sender

I've been able to make the patch. I think 3.3 is ready but may be it could go
to 3.3.1 if the patch is ok, of course.
Comment 4 Stephan Binner 2004-09-13 00:03:18 UTC 
Committed for KDE 3.3.1/3.4. Thanks for the patch. :-)