Bug 86068

Summary: Rule Editor dialog saves changes even if Cancel pressed
Product: [Unmaintained] knode Reporter: Jack D. Unrue <jdunrue>
Component: generalAssignee: kdepim bugs <pim-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: 0.7.7   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Jack D. Unrue 2004-07-27 05:23:26 UTC 
Version:           0.7.7 (using KDE KDE 3.2.3)
Installed from:    Gentoo Packages
Compiler:          g++ (GCC) 3.3.3 20040412 (Gentoo Linux 3.3.3-r6, ssp-3.3.2-2, pie-8.7.6) 
OS:                Linux

1) invoke Rule Editor from Scoring menu, add a new rule (criteria doesn't matter)
2) invoke Rule Editor again, select rule added in step 1
3) modify rule, e.g., change name, or change groups, etc.
4) click CANCEL
5) invoke Rule Editor a third time, select rule, see changes made in step 3
Comment 1 Volker Krause 2004-08-24 21:27:11 UTC 
CVS commit by vkrause: 

No need to update the scoring rule list after clicking on cancel, especially since this recovers the just discarded settings and thus always saves your changes.

CCMAIL: 86068-done@bugs.kde.org


  M +0 -1      kscoring.cpp   1.50


--- kdepim/libkdenetwork/kscoring.cpp  #1.49:1.50
@@ -1117,5 +1117,4 @@ void KScoringManager::popRuleList()
 {
   stack.pop(allRules);
-  emit changedRules();
 }