| Summary: | Some strings cannot be translated | ||
|---|---|---|---|
| Product: | [Applications] kolourpaint | Reporter: | Cédric Pasteur <cedric.pasteur> |
| Component: | general | Assignee: | Clarence Dang <dang> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
kolourpaint-rotate_skew-strings.diff
kolourpaint-crop-wrongstring.diff kolourpaint-i18n-pixmapfx-warn-about-loss-info.diff kolourpaint-i18n-preview-dialog.diff kolourpaint-i18n-resize-scale-dialog.diff kolourpaint-i18n-tools.diff |
||
|
Description
Cédric Pasteur
2004-07-23 15:07:30 UTC
On Fri, 23 Jul 2004 11:07 pm, Cédric Pasteur wrote: > KolourPaint use sometimes (in particular in tools) strange way to create to > create strings, which make those strings very hard to translate, or maybe > impossible in some languages. If you tell me specifically which ones, I can provides patches very quickly. > For example, in kptoolskew.cpp, there is " > Skewing the %1" where %1 is "image", "selection" or "text box". This works > good in English, but not with other languages. Ok, how's the attached patch (also removes strings for unreachable code paths)? Thanks, Clarence Created an attachment (id=6814) kolourpaint-rotate_skew-strings.diff Related to this bug report, attached patch fixes completely incorrect string. Created an attachment (id=6834) kolourpaint-crop-wrongstring.diff The patch fix the problem in those two files, but there are also other files which have the same problem: * kppixmapfx.cpp: 305 : "The %1 may have .." --> what is %1? Maybe you could also change this (and the related strings in the same file, eg "The %1 contains ..") * All strings related to key press (there are many in a lot of files) , eg : "%1 another line or %2 to finish." (in tools/kptoolpolygon.cpp:747) --> imho it would be better to have also the full sentence here. * in kptoolpreviewdialog.cpp: captionFromActionName () should be dropped, and all the strings should be complete; also with "After %1:" in the same file. * in tools/kptoolresizescale.cpp:129 "Text: %1 Box" * tools/kptoolrotate.cpp has the same problems as kptoolresizescale.cpp I also think that the messages about memory usage could all be merged in one more general such as : "This operation may take a substantial amount of memory. This can reduce system responsiveness and cause other application resource problems. Are you sure want to continue?" This could also be a solution for other strings. ------- Additional Comments From cedric.pasteur free fr 2004-07-26 13:49 > kppixmapfx.cpp: 305 : "The %1 may have .." --> what is %1? Maybe you > could also change this (and the related strings in the same file, > eg "The %1 contains ..") kolourpaint-i18n-pixmapfx-warn-about-loss-info.diff > All strings related to key press (there are many in a lot of files) , > eg : "%1 another line or %2 to finish." (in tools/kptoolpolygon.cpp:747) > --> imho it would be better to have also the full sentence here. kolourpaint-i18n-tools.diff > in kptoolpreviewdialog.cpp: captionFromActionName () should be dropped, > and all the strings should be complete; also with "After %1:" in the same > file. kolourpaint-i18n-preview-dialog.diff > in tools/kptoolresizescale.cpp:129 "Text: %1 Box" kolourpaint-i18n-resize-scale-dialog.diff > tools/kptoolrotate.cpp has the same problems as kptoolresizescale.cpp Do you mean 'i18n ("Selection: %1").arg (opName)' in kpToolRotateCommand::name()? Else I can't see where I've made a mistake. > I also think that the messages about memory usage could all be merged in > one more general such as : "This operation may take a substantial amount > of memory. This can reduce system responsiveness and cause other > application resource problems. Are you sure want to continue?" > This could also be a solution for other strings. Well, that's already been fixed in CVS with a lot of strings :) In general, I like the messages to be as precise as possible. Created an attachment (id=6921) kolourpaint-i18n-pixmapfx-warn-about-loss-info.diff Created an attachment (id=6922) kolourpaint-i18n-preview-dialog.diff Created an attachment (id=6923) kolourpaint-i18n-resize-scale-dialog.diff Created an attachment (id=6924) kolourpaint-i18n-tools.diff > Do you mean 'i18n ("Selection: %1").arg (opName)' in
> kpToolRotateCommand::name()?
> Else I can't see where I've made a mistake.
It seems you already have fixed this file. Sorry.
Thanks for fixing all these problems.
Will you commit those patches before kde3.3 ?
kde-i18n-doc people,
Is it ok to commit?
On Fri, 30 Jul 2004 10:51 pm, Cédric Pasteur wrote:
> Thanks for fixing all these problems.
> Will you commit those patches before kde3.3 ?
All these patch are good. But I'm afraid it might be too late for kde 3.3.0, as total freeze is on August 4th. I think you'd better commit them in KDE3_3_BRANCH after kde3.3.0 is out, because else translaters wouldn't have enough time to translate modified strings. Finally, I hope you'll avoid in he future those type of strings impossible to translate, without the need of a bug report to fix them. And thanks for fixing everything quickly. On Sun, 1 Aug 2004 04:06 am, Cédric Pasteur wrote:
> Finally, I hope you'll avoid in he future those type of strings impossible
> to translate, without the need of a bug report to fix them.
Sorry about that :)
Ok, I'll commit after 3.3.
CVS commit by dang: Update and apply patches to fix untranslatable strings. CCMAIL: 85785-done@bugs.kde.org, kde-i18n-doc@kde.org M +3 -0 NEWS 1.1.2.2 M +0 -2 TODO 1.66.2.2 M +24 -3 kpdocument.cpp 1.48.2.2 M +21 -3 kpmainwindow_edit.cpp 1.32.2.1 M +2 -1 pixmapfx/kpeffectsdialog.cpp 1.9.2.1 M +9 -35 pixmapfx/kppixmapfx.cpp 1.27.2.1 M +59 -26 pixmapfx/kppixmapfx.h 1.17.2.1 M +7 -63 tools/kptool.cpp 1.41.2.1 M +4 -6 tools/kptool.h 1.21.2.1 M +3 -6 tools/kptoolairspray.cpp 1.15.2.1 M +2 -3 tools/kptoolcolorpicker.cpp 1.14.2.1 M +3 -5 tools/kptoolfloodfill.cpp 1.13.2.1 M +1 -3 tools/kptoolpen.cpp 1.25.2.1 M +25 -43 tools/kptoolpolygon.cpp 1.19.2.1 M +5 -17 tools/kptoolpreviewdialog.cpp 1.14.2.1 M +5 -3 tools/kptoolpreviewdialog.h 1.7.2.1 M +3 -6 tools/kptoolrectangle.cpp 1.17.2.1 M +23 -18 tools/kptoolresizescale.cpp 1.30.2.1 M +3 -1 tools/kptoolrotate.cpp 1.19.2.1 M +1 -3 tools/kptoolselection.cpp 1.34.2.1 M +3 -1 tools/kptoolskew.cpp 1.18.2.1 CVS commit by dang: Update and apply patches to fix untranslatable strings. CCMAIL: 85785@bugs.kde.org M +3 -0 NEWS 1.1.2.1.2.3 M +0 -2 TODO 1.66.2.1.2.1 M +24 -3 kpdocument.cpp 1.48.2.1.2.2 M +21 -3 kpmainwindow_edit.cpp 1.32.4.2 M +2 -1 pixmapfx/kpeffectsdialog.cpp 1.9.4.2 M +9 -35 pixmapfx/kppixmapfx.cpp 1.27.4.2 M +59 -26 pixmapfx/kppixmapfx.h 1.17.4.1 M +7 -63 tools/kptool.cpp 1.41.4.2 M +4 -6 tools/kptool.h 1.21.4.2 M +3 -6 tools/kptoolairspray.cpp 1.15.4.2 M +2 -3 tools/kptoolcolorpicker.cpp 1.14.4.1 M +3 -5 tools/kptoolfloodfill.cpp 1.13.4.1 M +1 -3 tools/kptoolpen.cpp 1.25.4.1 M +25 -43 tools/kptoolpolygon.cpp 1.19.4.2 M +5 -17 tools/kptoolpreviewdialog.cpp 1.14.4.1 M +5 -3 tools/kptoolpreviewdialog.h 1.7.4.1 M +3 -6 tools/kptoolrectangle.cpp 1.17.4.1 M +23 -18 tools/kptoolresizescale.cpp 1.30.4.2 M +3 -1 tools/kptoolrotate.cpp 1.19.4.2 M +1 -3 tools/kptoolselection.cpp 1.34.4.2 M +3 -1 tools/kptoolskew.cpp 1.18.4.1 CVS commit by dang: Update and apply patches to fix untranslatable strings. CCMAIL: 85785@bugs.kde.org M +6 -0 NEWS 1.4 M +6 -2 TODO 1.70 M +24 -3 kpdocument.cpp 1.50 M +21 -3 kpmainwindow_edit.cpp 1.33 M +2 -1 pixmapfx/kpeffectsdialog.cpp 1.10 M +9 -35 pixmapfx/kppixmapfx.cpp 1.28 M +59 -26 pixmapfx/kppixmapfx.h 1.18 M +7 -63 tools/kptool.cpp 1.42 M +4 -6 tools/kptool.h 1.22 M +3 -6 tools/kptoolairspray.cpp 1.16 M +2 -3 tools/kptoolcolorpicker.cpp 1.15 M +3 -5 tools/kptoolfloodfill.cpp 1.14 M +1 -3 tools/kptoolpen.cpp 1.26 M +25 -43 tools/kptoolpolygon.cpp 1.20 M +5 -17 tools/kptoolpreviewdialog.cpp 1.15 M +5 -3 tools/kptoolpreviewdialog.h 1.8 M +3 -6 tools/kptoolrectangle.cpp 1.18 M +23 -18 tools/kptoolresizescale.cpp 1.31 M +3 -1 tools/kptoolrotate.cpp 1.20 M +1 -3 tools/kptoolselection.cpp 1.35 M +3 -1 tools/kptoolskew.cpp 1.19 |