Summary: | Log window appears without "Show log" checkbox checked | ||
---|---|---|---|
Product: | [Applications] kppp | Reporter: | Adam <adam> |
Component: | general | Assignee: | Harri Porten <porten> |
Status: | RESOLVED WORKSFORME | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Log window appears without "Show log" checkbox checked [patch] |
Description
Adam
2004-07-16 23:25:45 UTC
Such behaviour is exhibited because kppp keeps track of hiding debug window with Log button only. So when you close it with Close button, state in kppprc goes out of sync with what you see. Perhaps the following patch would help. It should be applied inside kppp directory and it changes debug.cpp and debug.h. Created attachment 6962 [details]
Log window appears without "Show log" checkbox checked [patch]
Comment on attachment 6962 [details]
Log window appears without "Show log" checkbox checked [patch]
Index: debug.cpp
===================================================================
RCS file: /home/kde/kdenetwork/kppp/debug.cpp,v
retrieving revision 1.19
diff -u -r1.19 debug.cpp
--- debug.cpp 25 Jun 2003 07:08:43 -0000 1.19
+++ debug.cpp 2 Aug 2004 07:32:40 -0000
@@ -132,6 +132,8 @@
show();
bool showlog = isVisible();
+ assert(p_kppp);
+ p_kppp->log->setChecked(showlog);
gpppdata.set_show_log_window(showlog);
}
Index: debug.h
===================================================================
RCS file: /home/kde/kdenetwork/kppp/debug.h,v
retrieving revision 1.11
diff -u -r1.11 debug.h
--- debug.h 7 Mar 2003 22:06:51 -0000 1.11
+++ debug.h 2 Aug 2004 07:32:43 -0000
@@ -29,7 +29,7 @@
#include <qlabel.h>
#include <qmultilineedit.h>
#include <qpushbutton.h>
-
+#include <qcheckbox.h>
class myMultiEdit : public QMultiLineEdit {
public:
Comment on attachment 6962 [details]
Log window appears without "Show log" checkbox checked [patch]
Index: debug.cpp
===================================================================
RCS file: /home/kde/kdenetwork/kppp/debug.cpp,v
retrieving revision 1.19
diff -u -r1.19 debug.cpp
--- debug.cpp 25 Jun 2003 07:08:43 -0000 1.19
+++ debug.cpp 2 Aug 2004 07:32:40 -0000
@@ -132,6 +132,8 @@
show();
bool showlog = isVisible();
+ assert(p_kppp);
+ p_kppp->log->setChecked(showlog);
gpppdata.set_show_log_window(showlog);
}
Index: debug.h
===================================================================
RCS file: /home/kde/kdenetwork/kppp/debug.h,v
retrieving revision 1.11
diff -u -r1.11 debug.h
--- debug.h 7 Mar 2003 22:06:51 -0000 1.11
+++ debug.h 2 Aug 2004 07:32:43 -0000
@@ -29,7 +29,7 @@
#include <qlabel.h>
#include <qmultilineedit.h>
#include <qpushbutton.h>
-
+#include <qcheckbox.h>
class myMultiEdit : public QMultiLineEdit {
public:
Sorry, my first patch is obsolete. I didn't find any way to remove or replace it. We only need to keep log checkbox in sync with its state in gpppdata. Looks like it's not necessary to track closing of log window with Close button, because user may just want to close it because he needs to cancel the connection, but not to disable log window at all. Dear Bug Submitter, This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond. Thank you for helping us make KDE software even better for everyone! Dear Bug Submitter, This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? Thank you for helping us make KDE software even better for everyone! Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version? If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you! Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone! |