Bug 84982

Summary:	Host part of news://host.name.tld/ URL is handled case sensitive
Product:	[Unmaintained] knode	Reporter:	Stefan Brüns <stefan.bruens>
Component:	general	Assignee:	kdepim bugs <pim-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Stefan Brüns 2004-07-12 08:09:52 UTC

Version:            (using KDE KDE 3.2.3)
Installed from:    SuSE RPMs

If I click on a news://host.name.tld/news.group style URL, and the newsserver is already in the list of newsservers used by me, but the hostname differs in case, a new account is added for this newsserver instead of using the existing account.

As far as I know, the hostname part of an URL is always case insensitive, so this should be changed.

If the cases match, the existing account is used, so this is wrong only for _differing_ host name cases.

I don't know of the news.group part of news:// URLs has to be handled case sensitive.

Comment 1 Roberto Teixeira 2004-07-22 20:05:06 UTC

CVS commit by maragato: 

Ignore case when comparing hostnames.

CCMAIL: 84982-done@bugs.kde.org


  M +1 -1      knmainwidget.cpp   1.44


--- kdepim/knode/knmainwidget.cpp  #1.43:1.44
@@ -476,5 +476,5 @@ void KNMainWidget::openURL(const KURL &u
     // lets see if we already have an account for this host...
     for(acc=a_ccManager->first(); acc; acc=a_ccManager->next())
-      if( acc->server()==host && (port==0 || acc->port()==port) )
+      if( acc->server().lower()==host.lower() && (port==0 || acc->port()==port) )
         break;