Bug 84802

Summary: konq wish: unclose tab
Product: [Applications] konqueror Reporter: missive
Component: tabbingAssignee: Konqueror Developers <konq-bugs>
Status: RESOLVED FIXED    
Severity: wishlist CC: elijahlofgren, geekboy, hkBst, me, oded, tusimi
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: unspecified   
OS: FreeBSD   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description missive 2004-07-09 14:20:59 UTC
Version:           3.2.3 (using KDE 3.2.3, compiled sources)
Compiler:          gcc version 2.95.4 20020320 [FreeBSD]
OS:                FreeBSD (i386) release 4.9-RELEASE-p11

I found a firefox extension the other day which allows to unclose the most recently closed tab. Very handy on the (all too unrare) oops!
Comment 1 Niels 2004-07-10 00:34:25 UTC
Opera also has this -- it keeps a long list of closed windows. I agree that it's a nice feature, and it could easily be added to the tools menu without causing confusion.
Comment 2 Stephan Binner 2004-07-11 11:31:01 UTC
Only a list of the URLs or also the state (form content, scroll position, cache, ...)?
Comment 3 Niels 2004-07-11 13:07:36 UTC
In Opera scroll position is remembered. Form content apparently not.
Comment 4 Stephan Binner 2005-01-25 18:28:41 UTC
*** Bug 92233 has been marked as a duplicate of this bug. ***
Comment 5 monstermunch 2005-02-10 18:04:51 UTC
It would be nice to add this as an "undo" action, as opposed to a "tool". For usability, you should always expect that the user will make mistakes and allow them to undo their actions. Putting it under tools isn't intuitive or easy to find as you are really looking to "undo" a mistake when you close a tab you didn't mean to. I tend to want to do this when I have, say, 5 tabs I closed by hitting the close button multiple times quickly but accidentally closed 6 tabs. The recently closed tabs list isn't going to be terrible different to the web history anyway so it doesn't add much. Having an "undo the last close action" is more convenient and quick to use.
Comment 6 Jakob Petsovits 2005-02-10 19:12:00 UTC
Undo means that it belongs to the Edit menu, and I don't think that unclosing a tab is an editing action.

Besides, the Undo command has to be specific to the current tab. So, if you trash a file, then close another tab and then press the Undo button, what will happen? Either the closed tab or the trashed file will come back, but it's not clear what will happen. I think this is not a good idea.

I'd expect an Unclose Tab command inside the tab bar's context menu, if it's there I don't mind where the appropriate menu entry lies. Maybe this would mean that the empty space on the tab bar should also get a context menu - a few of the commands are not specific to one tab.
Comment 7 monstermunch 2005-02-12 14:05:49 UTC
For usability though, you want to command to be visible and easy to find. I'm not sure what the best solution is, but putting it in a context menu is hidden and most users aren't going to find it. 
Comment 8 jos poortvliet 2005-03-11 01:09:53 UTC
but at least this should be implemented some way, as its very usefull ;-)
maybe keep the last closed tab visible, but grayed out (or as button: re-open)?

not really good, I think putting it in the contextmenu (rmb) for tabs is the best option, altough some users won't find it. but then, educate users: if you want to do something in KDE, try rmb! works very good, almost anything can be changed if you rmb click on it.
Comment 9 Stefan Nikolaus 2005-03-30 15:27:52 UTC
*** This bug has been confirmed by popular vote. ***
Comment 10 Carsten Schlipf 2006-01-27 10:59:15 UTC
Also see http://www.kde-look.org/content/show.php?content=34454.

IMHO an undo action would be the best and most consistent solution.
Comment 11 Stephan Sokolow 2006-06-03 02:08:23 UTC
I'd like to have a list of the most recent N (5?) closed tabs in a submenu of the context menu. As a power user, I am capable of taking a while to realize I wanted something.
Comment 12 Yaohan Chen 2006-06-03 02:32:50 UTC
I also vote for a menu listing the recently closed tabs. For its place in the menu, I think a few good choices are:
- In the Window menu, which already has tab operations like New Tab, Duplicate Current Tab.
- In the Go menu, near "Most Often Visited".
- In the Location menu. Many applications have a Recent list, and this list, although slightly different (these are not "saved" documents), still fits there. This might mean the items will go into the K Menu's Recent Documents list, which isn't a bad idea, as you would be able to naturally reopen a document which was the last tab in a Konqueror window.
- Of course, a toolbar button should be provided, and it would be nice if it could be placed on the tab bar.
Comment 13 Tommi Tervo 2006-08-06 12:59:16 UTC
*** Bug 131934 has been marked as a duplicate of this bug. ***
Comment 14 Marijn Schouten 2006-09-08 14:41:28 UTC
I don't care where in the menu this goes, as long as there is also a button to do it. 
Comment 15 Adrian 2006-09-28 11:56:41 UTC
I don't care where the menu or button are, there should be a shortcut for it "Ctrl-z" as in Opera.

By the way, Opera keeps the history of the closed page, if for example you typed something in a form it reopens the form with the text that you typed at the same place you were when you closed the page (or browser crashed)

That's very very useful, if for example the browser crashes or you close a page by mistake you will not lose data that you typed in. 
Comment 16 Sy Ali 2006-09-28 19:24:41 UTC
See also, bug 83803 (ask user to recover lost session if konqueror crashed)
Comment 17 Marijn Schouten 2006-09-28 19:29:29 UTC
if only i wasn't so short on konqueror votes... It's definately in the same category.
Comment 18 jos poortvliet 2006-10-20 07:57:12 UTC
@16 yes, being able to recover a lost session after a crash is very nice as well. there is already the 'crashes' plugin, it seems to be logical to ask to do it automatically... needs some work on the bug dialog, i guess, but still.

anyway, let's hope someone has time for this for KDE 4 :D
Comment 19 Maciej Pilichowski 2006-12-03 08:51:36 UTC
Yaohan (#12),
it fits "recent pages" perfectly -- kpdf does not save anything really, but "recent files" is a must (feature), so it is for Konqueror

Adrian (#15),
You can always set the shortcut for yourself and ctrl+z is not a good one. This is undo (consider editing textarea). Reopening pages with the last position and typed content is really useful feature

And about recovering from crash -- with the "reopen" feature the crash recovery would be just a subtask and maybe it would be hardly needed, beacause no matter crash or no crash you could be always able to reopen last pages.

Comment 20 Tommi Tervo 2006-12-08 12:44:15 UTC
http://lists.kde.org/?l=kfm-devel&m=116551394527885&w=2 may be interesting.
Comment 21 Adrian 2006-12-08 15:36:07 UTC
"ctrl+z is not a good one. This is undo (consider editing textarea)"

Ctrl-z is actually the Undo combination in Opera too, it works depending on what you do, for example if I delete something here and press Ctrl-z it will undo it, if I close the page and press Ctrl-z it will undo it by reopening it, however, if I edit something and I want to reopen the last page I can either click somewhere out of the input box and press Ctrl-z or press the default reopen page shortcut which in fact is Ctrl-Alt-z
Comment 22 Marijn Schouten 2006-12-08 15:37:52 UTC
sounds good
Comment 23 Maciej Pilichowski 2006-12-08 22:18:43 UTC
Adrian, technically speaking I think discussion is pointless, unless kdelibs would be redesigned to allow one shortcut for several actions (but from design point of view: I think that is the bad to introduce one key-combo for several things within one app, it is more clear to have distinct combos).
Comment 24 Lukáš Turek 2006-12-08 22:29:03 UTC
IMHO history of recently closed tabs is better than undo action. Sometimes I don't want to revive last closed tab, but some tab closed before last one.
Comment 25 Adrian 2006-12-08 23:44:15 UTC
"history of recently closed tabs is better than undo action" -- getting back to Opera example, Opera has a small trashcan in the tab bar, when you click on it you get a choice to reopen any closed tab of the session, that's really useful.

Maciej, thanks for explanation, it does make sense (of course this is a minor point as you said everyone can choose whatever shortcut they want)

Comment 26 Scott 2007-05-25 18:44:12 UTC
Firefox 2.0.x now has this function built-in by default. One right clicks on a tab and can select "undo closed tab".

Currently in Konqueror you can right-click on a tab and choose from "New Tab", "Duplicate Tab", "Reload Tab", "Close Tab", and "Detach Tab". "Undo Close tab" is a glaring omission there. :)

As noted previously this option is a default in both of the current versions of Firefox and Opera.

I would like to see it apply to kfm-only functions as well (just in case that's not a given :) ).
Comment 27 Scott 2007-07-08 19:40:59 UTC
This bug is almost 3 years old and is still marked "new"???

How "encouraging".....
Comment 28 Maciej Pilichowski 2007-07-08 21:13:37 UTC
> This bug is almost 3 years old and is still marked "new"??? 
> How "encouraging"..... 

"New" does not mean "posted recently" but "confirmed". I guess developers are busy working on hundreds of other reports, so if you are impatient you can contribute writing code by yourself. Also please keep in mind bugzilla is for discussing _technical_ issues.
 
Comment 29 Ganton 2007-11-25 12:55:49 UTC
For Scott and another people interested in how it is going, I can point them to:
  http://archives.devshed.com/forums/kde-96/new-featu-closed-tabs-trash-bin-as-in-opera-2089144.html

  http://commit-digest.org/issues/2007-11-18/moreinfo/737225/

  http://cia.vc/stats/author/dfaure/  [search the word "undo"]

Note: this information was valid in 2007-11-25 at least :-)
Comment 30 Tommi Tervo 2007-11-26 07:54:44 UTC
This wish is implemented now, credits goes to Eduardo Robles Elvira and David Faure.
Comment 31 FiNeX 2007-11-26 11:44:30 UTC
Wow, it works. There is only a problem: when the tab is reopened, the address bar field is not refreshed until the page is not focused/scrolled. Clicking on the label of the tab doesn't update the address bar.
Comment 32 Marijn Schouten 2009-08-24 19:32:06 UTC
Thanks a lot Eduardo Robles Elvira and David Faure.