Bug 84295

Summary:	adding rss feeds from konqueror does nothing
Product:	[Applications] akregator	Reporter:	Pierre Habouzit <madcoder>
Component:	general	Assignee:	Stanislav Karchebny <stanislav.karchebny>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Pierre Habouzit 2004-07-01 09:37:10 UTC

Version:            (using KDE KDE 3.2.2)
Installed from:    Debian testing/unstable Packages

09:28:27 <[MadCoder]> if you right click in konqui on a rss feed
09:28:37 <[MadCoder]> the 'add to akregator' don't work
09:33:52 <lippel> [MadCoder]: right, it doesnt add anything...

was mail-reported to me by John Belmonte :

Hello,

When I use "add feed to aKregator" from Konqueror, the feed does not
appear in akregator.  Are you aware of any such problem?  (bugs.kde.org
is down so I can't check upstream.)

-John

Comment 1 Frank Osterfeld 2004-07-01 10:09:09 UTC

CVS commit by osterfeld: 


fixes bug #84295. Search in DCOP interface for "akregatorIface" instead of "akregatorpart".

CCMAIL: 84295-done@bugs.kde.org


  M +4 -3      akregatorplugin.cpp   1.6


--- kdenonbeta/akregator/src/konq_plugin/akregatorplugin.cpp  #1.5:1.6
@@ -155,5 +155,5 @@ void AkregatorMenu::slotAddFeed()
         for (clientIt = akregatorObjs.begin(); (clientIt != akregatorObjs.end()) ; ++clientIt )
         {
-            if ((*clientIt).contains("akregatorpart", false) != 0)
+            if ((*clientIt).contains("akregatorIface", false) != 0)
             {
                 akregatorObj = *clientIt;
@@ -162,5 +162,6 @@ void AkregatorMenu::slotAddFeed()
             }
         }
-        if (akregatorObj.isNull()) return;
+        if (akregatorObj.isNull()) 
+            return;
 
         KFileItemListIterator it( m_list );

Comment 2 Mathieu Kooiman 2004-07-08 16:31:46 UTC

I'm on KDE 3.2.1, running CVS of Akregator but this is not entirely working for me. Add Feed To Akregator ONLY works when Akregator is not running. A new instance gets started and the feed gets added. If Akregator is already running. Nothing happens.

I've investigated it and there's a silly little error in the DCOP code you use. In src/konq_plugin/akregatorplugin.cpp on line 157 you have this:

        if ((*clientIt).contains("akregatorIface", false) != 0)

According to kdcop, akregator only exports aKregatorIface, with a capitalized K. I suppose this makes the contains() method case sensitive. Turning it into:

        if ((*clientIt).contains("aKregatorIface", false) != 0)

Fixes it.

Hope this helps.

Comment 3 Sashmit Bhaduri 2004-07-08 16:35:20 UTC

CVS commit by sashmit: 

add feed if akregator is running

thanks mathieu kooiman for the fix

CCMAIL: 84295@bugs.kde.org


  M +1 -1      akregatorplugin.cpp   1.7


--- kdenonbeta/akregator/src/konq_plugin/akregatorplugin.cpp  #1.6:1.7
@@ -155,5 +155,5 @@ void AkregatorMenu::slotAddFeed()
         for (clientIt = akregatorObjs.begin(); (clientIt != akregatorObjs.end()) ; ++clientIt )
         {
-            if ((*clientIt).contains("akregatorIface", false) != 0)
+            if ((*clientIt).contains("aKregatorIface", false) != 0)
             {
                 akregatorObj = *clientIt;