Bug 84019

Summary:	auto-away plugin should refrain from changing the Invisible status
Product:	[Unmaintained] kopete	Reporter:	Adeodato Simó <dato>
Component:	Auto-Away Plugin	Assignee:	Kopete Developers <kopete-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	SVN
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Adeodato Simó 2004-06-26 01:08:17 UTC

Version:           0.8.90 (CVS >= 20040616) (using KDE 3.2.3,  (testing/unstable))
Compiler:          gcc version 3.3.3 (Debian 20040422)
OS:                Linux (i686) release 2.6.6-1-686

[See also comments 5-14 in bug#76230.]

The auto-away plugin should check for the ::Invisible status and do nothing if the account is in such state.

This is very related to bug#62427, but at that time the ::Invisible status was not finally introduced and a little hack was done in the MSN plugin instead.

Now that the ::Invisible status exists, the auto-away plugin should handle it.

Comment 1 Olivier Goffart 2004-06-26 13:24:23 UTC

CVS commit by ogoffart: 

Fix Bug 84019 (auto-away plugin should refrain from changing the Invisible status)

The cause of that bug is a side effect of the introduction of the KOS Invisible. I'm sure there are other side effect we have to find.

CCMAIL: 84019-done@bugs.kde.org

P.S: there are not anymore auto-away plugin, all the away code is in libkopete


  M +3 -1      kopeteaway.cpp   1.37


--- kdenetwork/kopete/libkopete/kopeteaway.cpp  #1.36:1.37
@@ -25,4 +25,6 @@
 #include "kopeteaccountmanager.h"
 #include "kopeteaccount.h"
+#include "kopeteonlinestatus.h"
+#include "kopetecontact.h"
 #include "kopeteprefs.h"
 
@@ -390,5 +392,5 @@ void KopeteAway::setAutoAway()
         for(KopeteAccount *i=accounts.first() ; i; i=accounts.next() )
         {
-                if(i->isConnected() && !i->isAway())
+                if(i->myself()->onlineStatus().status() == KopeteOnlineStatus::Online)
                 {
                         d->autoAwayAccounts.append(i);

Comment 2 Till Gerken 2004-06-26 13:29:22 UTC

Please make this != Invisible, if we're ever going to support more away states in libkopete, it will have to be changed again.

Comment 3 Olivier Goffart 2004-06-26 13:58:08 UTC

!= Invisible,  != Offline,  != Away, and what ?

Adding more away states is not an easy task to perform. And it has a lot of side effect.

Read the comments of http://bugs.kde.org/show_bug.cgi?id=62427  
(Do not read Jason's comments, he understood nothing, and they are not interesting)
Comment #14 from Martijn is a good one.