Bug 83723

Summary: xine_artsplugin/configure.in.in doesn't disable plugin even if --without-arts is specified
Product: [Unmaintained] arts Reporter: Laurence Withers <l>
Component: xine_artspluginAssignee: Multimedia Developers <kde-multimedia>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: disable xine_artsplugin if arts is unwanted

Description Laurence Withers 2004-06-20 22:32:10 UTC 
Version:            (using KDE KDE 3.2.3)
Installed from:    Compiled From Sources
Compiler:          gcc 3.3.3 Gentoo R6
OS:                Linux

The kdemultimedia configure script doesn't disable compilation of
xine_artsplugin if arts isn't desired (e.g. --without-arts is specified on the
commandline).

Basically, xine_artsplugin/configure.in.in needs to check if arts is used and 
disable compilation of the subdir appropriately. I would provide a patch but
I can't get one to work, sorry :-(       (currently, it does check for xine,
just not for arts; other subdirs do seem to work, e.g. libaudiofile_artsplugin).
Comment 1 Stefan Gehn 2004-06-20 22:51:20 UTC 
Created attachment 6423 [details]
disable xine_artsplugin if arts is unwanted

simply copied from audiofile_artsplugin. As I use arts I didn't test the patch
Comment 2 Laurence Withers 2004-06-20 23:11:11 UTC 
That works fine... let's see Microsoft beat the turnaround time on this one :-)
(On a Sunday evening as well!).

Thanks very much, Stefan.
Comment 3 Laurence Withers 2004-07-16 00:30:12 UTC 
Any chance this could be added to CVS in time for 3.3.0 beta 2? It's the last 
bug I'm aware of that's stopping us from providing KDE on a Gentoo system
without arts.

Many thanks!
Comment 4 Stefan Gehn 2004-07-16 10:10:01 UTC 
guess why arts is part of kde, certainly not to disable it.
Comment 5 Laurence Withers 2004-07-16 11:07:46 UTC 
Sure, sure, but arts isn't for everyone :-)

Consider systems without soundcards, or with hardware mixers, etc. Combined
with high CPU usage (one of the Gentoo devs reports 20% CPU usage from arts on
his Apple laptop, dropping to 5% for sound without arts), there is some
motivation for achieving this.

Whilst I appreciate that fixing bugs in this vein isn't going to be high
priority, the "--disable-arts" configure machinery is already in place and
you've already written a working patch, so we might as well allow users
like me to live without arts. In fact, other than a couple of tricky bits, I
have a KDE 3.3 beta system running without arts right now, and it rocks!
Comment 6 Stefan Gehn 2004-07-16 11:17:24 UTC 
----------------------------
revision 1.13
date: 2004/06/23 15:32:36;  author: mlaurent;  state: Exp;  lines: +4 -0
Don't try to compile it when we use "--without-arts"


Well, he could have been so kind and closed this bug back then... :)