Summary: | disable as-you-type spell checking in all of KDE | ||
---|---|---|---|
Product: | [Unmaintained] kdelibs | Reporter: | Thorsten Staerk <dev> |
Component: | kspell | Assignee: | Zack Rusin <zack> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | canllaith, cubranic, g4mba5, kde.bugs, martin.piskernig, torquil, tuju |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | RedHat Enterprise Linux | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: |
no spellcheck in konqueror
allow setting "no spellcheck" in configuration |
Description
Thorsten Staerk
2004-06-15 17:01:39 UTC
I fully support this wishlist item. Please at least add an option to disable spell-checking in the control center! A quick hackish way to disable spell checking is to edit $HOME/.kde/share/config/kdeglobals and in the [KSpell] section turn all values to 0. On Saturday 09 October 2004 18:51, Martin Piskernig wrote:
> I fully support this wishlist item.
Please vote for it then. Currently this bug has zero votes which to me
indicates that there is not much demand for disabling spell-checking
by default.
*** This bug has been confirmed by popular vote. *** This should be a bug not a wish. I use textares a lot in my work (i.e. PHP MyAdmin query dumps, etc...) and this feature freezes my computer. It also makes typing slow down to about 10-20 wpm. Either make it work right or global disable it. Joshua is right, this is not a wishlist but rather a minor bug. I fully agree. There should be an option to disable this, and that should be on by default. I cannot find one in KDE 3.5.0. Right now I'm typing a mix of red and black words, just because my spell checking is per default configured for Norwegian, on my computers. Really annoying. It's also sensitive to CPU, meaning if I've got heavy background tasks running, typing in Konqueror text areas is sluggish. If you start a new mail, you can go into Option -> Automatic Spellchecking and turn it off/on. Its not a good place to have it, but atleast it works. Reply to comment #8: >If you start a new mail, you can go into Option -> Automatic Spellchecking >and turn it off/on. Its not a good place to have it, but atleast it works. I've already done this, but it doesn't have have any effect for Konqueror text areas. I'm almost grateful it doesn't, because that would be an awful place for options affecting other apps than Kmail itself. Reply to comment #8: >If you start a new mail, you can go into Option -> Automatic Spellchecking >and turn it off/on. Its not a good place to have it, but atleast it works. I know. It took me 2 hours to implement it - as Oyvind states, it is only kmail specific - while I am typing this, Oyvind, kmail and kspell are written red by kspell - a fact that I really dislike. Thanks for your votes the relevant code is in kdelibs4_snapshot/kspell2/kcmspellchecking/spellchecking.cpp Created attachment 13977 [details]
no spellcheck in konqueror
okay, this patch disables spell checking in konqueror. Still to be refined:
1. think if there is a possibility to let the different dictionaries return
"correctly spelled" for every word
2. set up a global-config-setting or so saying "do spellcheck" and honor this
setting
Created attachment 13998 [details]
allow setting "no spellcheck" in configuration
This preliminary patch allows you to set "do spellcheck" in kcontrol. Next step
must be that kspell looks at this setting and quits work if it is not set.
SVN commit 495333 by tstaerk: Allow to turn spellchecking on/off. Avoids one crash in KDE 4's konqueror. This shall be forwardported to kdelibs. CCBUGS:83423 M +45 -10 ksconfig.cpp M +9 -1 ksconfig.h M +41 -34 kspelldlg.cpp SVN commit 495495 by dfaure: Forwardport 495333 by tstaerk, "Allow to turn spellchecking on/off", after fixing the bool<->int conversions, but this doesn't change the fact that those classes are deprecated in favour of kspell2, which means that khtml should be ported to kspell2 [not this weekend though]. CCMAIL: Thorsten Staerk <dev@staerk.de>, 83423@bugs.kde.org M +45 -10 ksconfig.cpp M +9 -1 ksconfig.h M +41 -34 kspelldlg.cpp I believe this bug is duplicated in at least bug 92340 (which has another 100 votes in it), 110573, and 120287. *** Bug 92340 has been marked as a duplicate of this bug. *** *** Bug 110573 has been marked as a duplicate of this bug. *** *** Bug 120287 has been marked as a duplicate of this bug. *** Uhh, some of you guys really need to read this: http://ometer.com/free-software-ui.html specifically on the "Standing up to user pressure" section... Yes, I know this seems like a troll, but come on... SVN commit 542801 by tstaerk: Give a possibility to disable SpellChecking already in KDE 3.5.3. To do it, set KSpell_DoSpellChecking=0 in the [KSpell] section of kdeglobals. BUGS:83423 CCBUGS:109389 M +24 -20 ksyntaxhighlighter.cpp --- branches/KDE/3.5/kdelibs/kdeui/ksyntaxhighlighter.cpp #542800:542801 @@ -334,28 +334,32 @@ void KDictSpellingHighlighter::slotSpellReady( KSpell *spell ) { kdDebug(0) << "KDictSpellingHighlighter::slotSpellReady( " << spell << " )" << endl; - if ( d->globalConfig ) { - connect( d->sDictionaryMonitor, SIGNAL( destroyed()), - this, SLOT( slotDictionaryChanged() )); - } - if ( spell != d->spell ) + KConfigGroup cg( KGlobal::config(),"KSpell" ); + if ( cg.readEntry("KSpell_DoSpellChecking") != "0" ) { - delete d->spell; - d->spell = spell; + if ( d->globalConfig ) { + connect( d->sDictionaryMonitor, SIGNAL( destroyed()), + this, SLOT( slotDictionaryChanged() )); + } + if ( spell != d->spell ) + { + delete d->spell; + d->spell = spell; + } + d->spellReady = true; + const QStringList l = KSpellingHighlighter::personalWords(); + for ( QStringList::ConstIterator it = l.begin(); it != l.end(); ++it ) { + d->spell->addPersonal( *it ); + } + connect( spell, SIGNAL( misspelling( const QString &, const QStringList &, unsigned int )), + this, SLOT( slotMisspelling( const QString &, const QStringList &, unsigned int ))); + connect( spell, SIGNAL( corrected( const QString &, const QString &, unsigned int )), + this, SLOT( slotCorrected( const QString &, const QString &, unsigned int ))); + d->checksRequested = 0; + d->checksDone = 0; + d->completeRehighlightRequired = true; + d->rehighlightRequest->start( 0, true ); } - d->spellReady = true; - const QStringList l = KSpellingHighlighter::personalWords(); - for ( QStringList::ConstIterator it = l.begin(); it != l.end(); ++it ) { - d->spell->addPersonal( *it ); - } - connect( spell, SIGNAL( misspelling( const QString &, const QStringList &, unsigned int )), - this, SLOT( slotMisspelling( const QString &, const QStringList &, unsigned int ))); - connect( spell, SIGNAL( corrected( const QString &, const QString &, unsigned int )), - this, SLOT( slotCorrected( const QString &, const QString &, unsigned int ))); - d->checksRequested = 0; - d->checksDone = 0; - d->completeRehighlightRequired = true; - d->rehighlightRequest->start( 0, true ); } bool KDictSpellingHighlighter::isMisspelled( const QString &word ) reopening just in order to be able to move it to the right product since this is obviously not a kmail specific report and closing again. sorry for the noise. see also 110835 please remove KMEdit::setSpellCheckingActive from kmail 109389 give a possibility to disable as-you-type spell checking |