| Summary: | Option --notabbar interferes with --schema=<transparent schema> | ||
|---|---|---|---|
| Product: | [Applications] konsole | Reporter: | Jorge Adriano <jorge.adriano> |
| Component: | general | Assignee: | Konsole Developer <konsole-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dino |
| Priority: | NOR | ||
| Version: | 1.3.2 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
|
Description
Jorge Adriano
2004-06-10 18:24:43 UTC
Yepper, same on CVS... konsole --notabbar --schema Transparent_lightbg doesn't work (grayish bg color, no transparency). Moreover, it is not identical to running konsole without any arguments (white bg color, no trans). Afterwards, changing the schema via the menu works. In main.cpp, around line 545: 1. If --notabbar is given, m->show() does not "call" activateSession() 2. If --notabbar is NOT given, then activateSession is "called". I tested this using kdDebug() statements... Hack to fix this bug is to add m->activateSession(0); before the m->show() line in main.cpp. However, as to the real reason for this... dunno. Note also, that this bug is for transparent schemas ONLY! To reproduce, --schema=<transparent schema> must be on the command line. Having it as the 'default' will not trigger this bug.
It doesn't matter if the notabbar is given on the command line or is the 'default'.
This below patch seems kinda hackish. It fixes the bug, but it might be nice to know why...
Index: main.cpp
===================================================================
RCS file: /home/kde/kdebase/konsole/konsole/main.cpp,v
retrieving revision 1.267
diff -u -p -r1.267 main.cpp
--- main.cpp 10 Jul 2004 15:51:52 -0000 1.267
+++ main.cpp 18 Jul 2004 06:27:29 -0000
@@ -536,6 +536,7 @@ extern "C" int kdemain(int argc, char* a
if (schema.right(7)!=".schema")
schema+=".schema";
m->setSchema(schema);
+ m->activateSession(0); // fixes BR83162
}
ksm->konsole = m;
CVS commit by hindenburg:
Fix bug when --schema=<some transparent schema> and the tabbar is hidden.
BUG: 83162
M +1 -0 main.cpp 1.277
--- kdebase/konsole/konsole/main.cpp #1.276:1.277
@@ -557,4 +557,5 @@ extern "C" int KDE_EXPORT kdemain(int ar
schema+=".schema";
m->setSchema(schema);
+ m->activateSession(0); // Fixes BR83162, transp. schema + notabbar
}
|