| Summary: | [testcase]Cannot import class which ends with a comment | ||
|---|---|---|---|
| Product: | [Applications] umbrello | Reporter: | Martin Koller <martin> |
| Component: | general | Assignee: | Oliver Kellogg <okellogg> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | roberto |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
Confirmed, how peculiar. I've fixed it for the common case of a trailing comment on a member variable:
class TEST {
int x; // just a comment
};
Roberto, I think this could be a candidate for backporting to kdevelop (?)
See
kdesdk/umbrello/umbrello/classparser/parser.h rev. 1.2
kdesdk/umbrello/umbrello/classparser/parser.cpp rev. 1.4
*** Bug has been marked as fixed ***. I find that it still doesn't work for enums:
enum MyEnumType {
zero, // ouch, this comment throws us off the handle
one
};
As soon as there's a comment at the end of an enum literal
the class import for the enum, including any surrounding scope
such as class or namespace, fails.
I have the fix for this ready - should I commit?
fixed by parser.cpp:1.6 |
Version: 1.2.90 (using KDE 3.2.90 (3.3 alpha1, CVS >= 20040522), compiled sources) Compiler: gcc version 3.2.3 OS: Linux (i686) release 2.4.22 The simple following class can not be imported. If I remove the comment line, then it works. class TEST { // just a comment };