Bug 82898

Summary:	juk renaming file removes part from comment field
Product:	[Frameworks and Libraries] taglib	Reporter:	Marco Krohn <marco.krohn>
Component:	general	Assignee:	Scott Wheeler <wheeler>
Status:	RESOLVED FIXED
Severity:	normal	CC:	micha
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Marco Krohn 2004-06-05 19:03:19 UTC

Version:           2.0.81 (using KDE 3.2.90 (3.3 alpha1, CVS >= 20040522), compiled sources)
Compiler:          gcc version 3.3.3 (Debian 20040401)
OS:                Linux (i686) release 2.4.23-1-k7

1. add the following text to the comment field: "downloaded from garageband.com (with permission)" (without '"')
2. rename file (CTRL+R)
3. the comment entry now reads "downloaded from garageband.c"

I have tested various other entries in the comment field, but didn't find any other entry that behaves in a similar way. Strange.

Comment 1 Marco Krohn 2004-06-05 19:05:29 UTC

It seems this time bugs.kde.org didn't add the summary information:

2.0.81 (KDE 3.2.90 (3.3 alpha1, CVS >= 20040522), compiled sources)
Linux (i686) release 2.4.23-1-k7
gcc version 3.3.3 (Debian 20040401)

Comment 2 Michael Pyne 2004-06-06 07:30:58 UTC

I can confirm this bug over here, although the it's not the Renamer's fault.  From my testing over here, if you have a file that only contains an ID3v1 tag, then the comment field will be truncated after writing out to the file.  You can confirm this by adding a comment, saving it, and then refreshing the tag.

However, once JuK has written to the file, the next tag it writes will be in the ID3v2 format, which can hold a much longer comment.

I'm pretty sure that JuK or the underlying taglib is supposed to detect when ID3v2 is necessary and switch automatically, but we'll probably have to have Scott investigate this further.

Comment 3 Scott Wheeler 2004-07-26 04:29:15 UTC

This is a TagLib issue, so I'm moving it there.  (And actively working on it at the moment.)

Comment 4 Scott Wheeler 2004-07-26 05:14:09 UTC

CVS commit by wheeler: 

Provide a default (empty) value for the language.  The lack thereof was was
causing the bytes to not get lined up properly in the newly written tag and
then they weren't read back properly.

CCMAIL:82898-done@bugs.kde.org


  M +1 -1      commentsframe.cpp   1.19


--- kdesupport/taglib/mpeg/id3v2/frames/commentsframe.cpp  #1.18:1.19
@@ -134,5 +134,5 @@ ByteVector CommentsFrame::renderFields()
 
   v.append(char(d->textEncoding));
-  v.append(d->language);
+  v.append(d->language.size() == 3 ? d->language : "   ");
   v.append(d->description.data(d->textEncoding));
   v.append(textDelimiter(d->textEncoding));

Comment 5 Scott Wheeler 2004-08-10 10:41:37 UTC

*** Bug 86892 has been marked as a duplicate of this bug. ***