Bug 82685

Summary: Support nesting of class inside class
Product: [Applications] umbrello Reporter: Oliver Kellogg <okellogg>
Component: generalAssignee: Joris Steyn <kde>
Status: RESOLVED FIXED    
Severity: wishlist CC: kde, ralf.habacker
Priority: NOR    
Version: unspecified   
Target Milestone: 2.11 (KDE 4.11)   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: http://commits.kde.org/umbrello/cc23836675e353b11ea5ca40aa4a3251c19342b1 Version Fixed In: 4.11.4
Sentry Crash Report:

Description Oliver Kellogg 2004-06-02 07:40:42 UTC 
Version:            (using KDE Devel)
Installed from:    Compiled sources

On importing C++ classes into Umbrello, nested classes
are moved to outside the scope of their containing class.
It would be desirable to maintain the nesting.
This applies to C++ in particular. I'm not sure whether
other languages support the nesting. Also I'm not sure
what the UML standard says about this (?) but a number
of other professional UML tools support it.
Comment 1 Oliver Kellogg 2004-06-20 18:05:39 UTC 
*** Bug has been marked as fixed ***.
Comment 2 Oliver Kellogg 2013-09-10 03:15:07 UTC 
This needs to be looked again.
While it might still work on code import (?) , nesting of classes cannot be achieved via GUI actions. See also http://commits.kde.org/umbrello/c63e77ca04b691b304a391d5b926ac0f0667e974
Comment 3 Joris Steyn 2013-11-14 14:46:13 UTC 
Git commit 2d7916547b41d3848136eaeccde23f5f2172ac2b by Joris Steyn.
Committed on 14/11/2013 at 14:43.
Pushed by jorissteyn into branch 'master'.

Support nesting of class in class

GUI support was removed in 4.11.3 for no valid reason. This commit adds it back
and also works with drag/drop operations.

Additional fix: don't lose stereotype of package when nested in class.

M  +2    -1    umbrello/classifier.cpp
M  +1    -0    umbrello/clipboard/umldragdata.cpp
M  +3    -1    umbrello/model_utils.cpp

http://commits.kde.org/umbrello/2d7916547b41d3848136eaeccde23f5f2172ac2b
Comment 4 Ralf Habacker 2013-11-14 14:50:52 UTC 
(In reply to comment #3)
> GUI support was removed in 4.11.3 for no valid reason. This commit adds it
> back and also works with drag/drop operations.
which means this a candidate for backporting to 4.11 branch
Comment 5 Joris Steyn 2013-11-14 15:11:59 UTC 
Git commit 9d2ad4d0b7e00cfdf5ca01cbb485c0be6301a02c by Joris Steyn.
Committed on 14/11/2013 at 14:43.
Pushed by jorissteyn into branch 'KDE/4.11'.

Support nesting of class in class

GUI support was removed in 4.11.3 for no valid reason. This commit adds it
back. Backport of 2d79165.

M  +3    -1    umbrello/model_utils.cpp

http://commits.kde.org/umbrello/9d2ad4d0b7e00cfdf5ca01cbb485c0be6301a02c
Comment 6 Ralf Habacker 2013-11-14 15:41:36 UTC 
Git commit cc23836675e353b11ea5ca40aa4a3251c19342b1 by Ralf Habacker, on behalf of Joris Steyn.
Committed on 14/11/2013 at 14:43.
Pushed by habacker into branch 'KDE/4.12'.

Support nesting of class in class

GUI support was removed in 4.11.3 for no valid reason. This commit adds it
back.
(cherry picked from commit 9d2ad4d0b7e00cfdf5ca01cbb485c0be6301a02c)

M  +3    -1    umbrello/model_utils.cpp

http://commits.kde.org/umbrello/cc23836675e353b11ea5ca40aa4a3251c19342b1