Summary: | [test case] Caption width is too short | ||
---|---|---|---|
Product: | [Applications] konqueror | Reporter: | Mattias Hermansson <mattias> |
Component: | khtml renderer | Assignee: | Konqueror Developers <konq-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | hadmut, lex.lists |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: | test case |
Description
Mattias Hermansson
2004-05-26 20:31:50 UTC
Webpage is no longer active. Sorry. Apache daemon went down. Webpage problem fixed. Site couldn't be visited 2005-April-19 Mattias, I'm not 100% what the problem is. Can you please clarify what the problem is? The problem is that the caption isn't rendered over the entire table. If you look at the right border, where the table and caption meet, you see that the caption is shorter than the rest of the table. Mattias, the above links are currently broken. Please consider creating attachments of those files so that your bug can be worked on regardless of the status of your web server. Created attachment 12060 [details]
test case
Caption is two pixels narrower than table (3.5-branch)
*** Bug 123952 has been marked as a duplicate of this bug. *** SVN commit 596875 by carewolf: captions are independent of tables border and padding BUG: 82266 M +4 -0 render_box.cpp --- branches/KDE/3.5/kdelibs/khtml/rendering/render_box.cpp #596874:596875 @@ -707,6 +707,10 @@ } RenderBlock* cb = containingBlock(); + if (isRenderBlock() && cb->isTable()) { + //captions are not affected by table border or padding + return cb->width(); + } if (usesLineWidth()) return cb->lineWidth(m_y); else + if (isRenderBlock() && cb->isTable()) { + //captions are not affected by table border or padding this doesn't screen out table cells, or I'm missing something? SVN commit 618852 by ggarand: don't let other elements go in there e.g. <table border=5><tr><td style=position:relative;left:100%>X CCBUG:82266 M +1 -1 render_box.cpp M +1 -0 render_table.h --- trunk/KDE/kdelibs/khtml/rendering/render_box.cpp #618851:618852 @@ -707,7 +707,7 @@ } RenderBlock* cb = containingBlock(); - if (isRenderBlock() && cb->isTable()) { + if (isRenderBlock() && cb->isTable() && static_cast<RenderTable*>(cb)->caption() == this) { //captions are not affected by table border or padding return cb->width(); } --- trunk/KDE/kdelibs/khtml/rendering/render_table.h #618851:618852 @@ -162,6 +162,7 @@ CollapsedBorderValue* currentBorderStyle() { return m_currentBorder; } RenderTableSection *firstBodySection() const { return firstBody; } + RenderFlow* caption() const { return tCaption; } protected: |