Bug 82028

Summary: SDL template (Appwizard) doesn't work properly, I have PATCH
Product: [Applications] kdevelop Reporter: Konrad Materka <materka>
Component: generalAssignee: KDevelop Developers <kdevelop-devel>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 3.0.3   
Target Milestone: ---   
Platform: Debian testing   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Konrad Materka 2004-05-22 22:30:34 UTC
Version:           3.0.3 (using KDE KDE 3.2.2)
Installed from:    Debian testing/unstable Packages
OS:                Linux

After creating new program in Appwizard from SDL template program doesn't compile on my system (Debian SID). g++ can't find file SDL.h, because in Debian rhis file is palced in /usr/include/SDL/, not in /usr/include/.
G++ can't find file because ./configure and make don't use sdl-config properly. Output from sdl-config --cflags is not commited to CXXFAGS variable. Litle change in file: configure.in resolve this problem:

diff -u configure.in configure.in.old
--- sdlbomber_1/configure.in    2004-05-22 19:56:27.000000000 +0000
+++ sdlbomber/configure.in      2004-05-22 21:32:26.000000000 +0000
@@ -78,11 +78,11 @@
      done
      LIBSDL_RPATH=`echo $LIBSDL_RPATH | sed -e "s/-L/-R/g"`
      LIBSDL_CFLAGS="`$LIBSDL_CONFIG --cflags`"
+     CXXFLAGS="$CXXFLAGS $LIBSDL_CFLAGS"

      AC_DEFINE_UNQUOTED(HAVE_LIBSDL, 1, [Defines if your system has the LIBSDL library])
 fi

-
 AC_SUBST(LIBSDL_LIBS)
 AC_SUBST(LIBSDL_CFLAGS)
 AC_SUBST(LIBSDL_RPATH)


I have added one line:
CXXFLAGS="$CXXFLAGS $LIBSDL_CFLAGS"

I know that this is not the smartest move in the world, but... it works perfectly!
Could you correct SDL template?
If you have any question about this send me a e-mail:
kmaterka@wp.pl or konrad@linux.pl
Comment 1 Matt Rogers 2004-12-12 06:27:50 UTC
CVS commit by mattr: 

Switch INCLUDES to AM_CPPFLAGS since INCLUDES is deprecated and has
apparently been so since at least automake 1.7.8 (according the manual)

Also, move $(LIBSDL_CFLAGS) to AM_CPPFLAGS. Should fix bug 82028

BUG: 82028


  M +1 -2      src-Makefile.am   1.3


--- kdevelop/languages/cpp/app_templates/cppsdlhello/src-Makefile.am  #1.2:1.3
@@ -3,8 +3,7 @@
 
 # set the include path found by configure
-INCLUDES= $(all_includes)
+AM_CPPFLAGS = $(all_includes) $(LIBSDL_CFLAGS)
 
 # the library search path.
 %{APPNAMELC}_LDFLAGS = $(all_libraries) $(LIBSDL_RPATH)
-%{APPNAMELC}_CXXFLAGS = $(LIBSDL_CFLAGS)
 %{APPNAMELC}_LDADD = $(LIBSDL_LIBS)