| Summary: | [patch] location bar text being clipped when opening new tab | ||
|---|---|---|---|
| Product: | [Applications] konqueror | Reporter: | Reuben <reuben_p> |
| Component: | tabbing | Assignee: | Konqueror Developers <konq-bugs> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | normal | CC: | alx5000, arnaud_oss, bytewise, cdauth+bugs.kde.org, faure, jerzy.kozera, kjelderg, lex.lists, m.mauder, mihnea_capraru, yansanmo.site |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Debian testing | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | sets 'immediate' in KonqViewManager::setActivePart to true by default | ||
|
Description
Reuben
2004-05-16 14:33:30 UTC
*** Bug 101464 has been marked as a duplicate of this bug. *** this bug is over one year old and has been reported several times as new since with every new version of KDE can please someone at least confirm this one? I can confirm this, if that means anything (KDE 3.4.0.b from Suse 9.3 auto-updated) or better: solve it ;-) maybe its not the worst bug ever, but very annoying nevertheless Problem confirmed here (kde 3.4.1). It occurs most often when the URL typed matches something in the URL-history. I use "gg:" frequently, so the easiest way for me to dup the problem is hit Ctrl-T and immediately type "gg:". The "gg" disappears. *** Bug 100830 has been marked as a duplicate of this bug. *** This bug is still occuring with Konqueror from KDE 3.5 beta1. The address bar is cleared after some delay - this time span could be used by user for typing something in address bar, after what it gets cleared. It's caused by KonqViewManager::setActivePart function having 'immediate' argument set to false by default. I'm attaching patch for konqueror from kdebase-3.4.91 that sets 'immediate' to true by default - it makes the bug not occur for me anymore. I don't know if it won't break anything as I'm not Konqueror developer and I don't feel like analysing its code further now.. But from what I've seen so far, there isn't any reason to worry about. :) The KonqMainWindow::setLocationBarURL is called three times when creating new tab, probably fixing this somehow could help with improving overall performance. HTH. Created attachment 12973 [details]
sets 'immediate' in KonqViewManager::setActivePart to true by default
confirming for kde 3.4.3 from kubuntu breezy *** Bug 118645 has been marked as a duplicate of this bug. *** In fact, I feel this bug in KDE 3.5 worse than in KDE 3.4. *** Bug 119780 has been marked as a duplicate of this bug. *** bug #119780 has patch too. *** Bug 122331 has been marked as a duplicate of this bug. *** *** Bug 127901 has been marked as a duplicate of this bug. *** KDE 3.5 on SUSE, and it's got worse than in the past. I just wanted to report this, I did not find it under this description (how is that possible, it gave me only about 80 bugs with "location" in title and this one was not there???) but the search for similar bugs led me here ... I am afraid that this problem is worse that just clipping the text, to me it seems that the whole location bar gets initialised (and thus redrawn) twice ... but its hard to prove and I am not a programmer to find it within the code :-/ as for comment #3, the problem is independent of the url history, the problem appears everytime, even if the address does not match anything (but drawing the history suggestions drop-down takes some time which may delay the exact moment when the text gets cleared, thus giving you more time to type something and making it more noticeable) Come on... Konqueror developers... This thing is 2 years old now and 2 patches have been submitted. Isn't it possible to at least give a statement on this one? Thanks. *** Bug 129220 has been marked as a duplicate of this bug. *** I can reproduce it in konqueror 4 svn trunk 831729 (it only deletes one letter in a 200Mhz machine). I press the create new tab button in the tabs list, press querty while it is creating the new tab, and the q is deleted. This happens before the about:blank appears in the tab label, while the <x| icon is grey (disabled), I'm not able to reproduce it if the new tab is created by the keyboard shortcut (Ctrl+Shift+N). I cannot reproduce this with konqueror 4.3.4 nor with 4.4.0-svn. Qt-4.6. Based on the last comment I tried "click on new tab button and start typing quickly" many times, and the text always ends up in the location bar, even though I see the new tab pop up after I type the text -- of course my machines are much more powerful than 200 MHz, but if I see the tab appear after I type, hopefully that's a good testcase of the issue? Can anyone reproduce this in konqueror trunk (4.4, with Qt-4.6)? I don't seem to have the problem anymore. Cannot reproduce it on a KDE 4.3.3 with Qt 4.5.3 either. If it only deletes 1 letter on a 200 MHz machine, I think that is acceptable and is nothing compared to the original problem. Thanks for the comments, closing the bug then. |