Bug 80226

Summary:	PATCH: Allow full paths when specifying --keytab=
Product:	[Applications] konsole	Reporter:	Kurt Hindenburg <khindenburg>
Component:	general	Assignee:	Konsole Developer <konsole-devel>
Status:	RESOLVED LATER
Severity:	wishlist
Priority:	NOR
Version:	CVS
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Patch to allow full filenames in --keytab Adds ability to use absolute filenames in --keytab=; also adds --keytabs Adds ability to use absolute filenames in --keytab=; also adds --keytabs code for --keytrans

Description Kurt Hindenburg 2004-04-23 21:13:51 UTC

Version:            (using KDE Devel)
Installed from:    Compiled sources
OS:          Linux

Playing around with bug 37652, I found that you can't do --keytab=/tmp/TEST.keytab

This patch allows full filenames and also checks to see if the keytab already exists (otherwise user would get confused on why their specified keytab was not
being used [ie. --keytab=/tmp/linux.keytab]).
I personally don't like that konsole stores the keytabs by filename; perhaps by 'keyboard' would be better.

Comment 1 Kurt Hindenburg 2004-04-23 21:14:51 UTC

Created attachment 5750 [details]
Patch to allow full filenames in --keytab

Comment 2 Waldo Bastian 2004-05-25 19:02:11 UTC

The QFile::encodeName should be done before QFile::exists already, and the QFile::exists should only be done if the file starts with a "/" IMHO.

While you are at it, you may also wish to add a --keytabs option which lists all available keytabs, just like --schemas, --profiles and --types.

Comment 3 Kurt Hindenburg 2004-05-26 19:26:09 UTC

Created attachment 6133 [details]
Adds ability to use absolute filenames in --keytab=; also adds --keytabs

Comment 4 Kurt Hindenburg 2004-05-26 19:47:35 UTC

The --keytabs is not entirely correct.  The default keytab 'default.Keytab' is not listed as it is not a *.keytab file.

This may confuse users when/if they try to find where XTerm (XFree 4.x.x) comes from...  (i.e. I have 5 items in the Keyboard menu, and --keytabs only lists 4 files).

Should I also include 'default.Keytab' in the list?  Why is default.Keytab not default.keytab?

Comment 5 Waldo Bastian 2004-05-26 22:57:43 UTC

The two "QString keytab = QFile::encodeName(keyTab);" lines are wrong and not needed at all. Instead, the line
	keytab = args->getOption("keytab");
should read:
	keytab = QFile::decodeName(args->getOption("keytab"));

default.Keytab is a compiled-in default, it isn't actually read from disk and default.Keytab is only added for documentation purposes. Maybe it should be renamed to "default.keytab.readme" to make that more clear.

I suggest to list it as "default", without .keytab or .Keytab

Comment 6 Kurt Hindenburg 2004-05-27 07:44:03 UTC

Created attachment 6138 [details]
Adds ability to use absolute filenames in --keytab=; also adds --keytabs

.K. Here the new patch with the decodeName changes.

I added a message about using any other keytab string.	IMHO using the
'buildin' as the default is a bug; konsole should use the 'default saved'.
I also think a warning should be printed if the given keytab is not found (ie.
--keytab thiskeytab).
But not with the bug report.

I think renaming default.Keytab to default.keytab.readme is a very good idea.

Comment 7 Kurt Hindenburg 2004-09-28 19:03:55 UTC

Created attachment 7711 [details]
code for --keytrans

This is half of this bug report; the --keytrans list.  I'll do the other half
shortly.

Comment 8 Robert Knight 2007-02-10 04:12:19 UTC

Will look into this.

Comment 9 Robert Knight 2008-07-13 02:59:39 UTC

Dropping this patch as it does not apply to the current version of Konsole (KDE 4)