| Summary: | Wish: Replace technical term "Filter" with "File format" or "File type" when dialog displays a combobox of file types | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | Dik Takken <kde> |
| Component: | Open/save dialogs | Assignee: | David Faure <faure> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | bfeber, bugseforuns, kdelibs-bugs-null, nate, nicolasg |
| Priority: | NOR | Keywords: | junior-jobs, usability |
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kio/f0668888660ffcbe578884c5e80cef53b16be50d | Version Fixed/Implemented In: | 5.59 |
| Sentry Crash Report: | |||
|
Description
Dik Takken
2004-04-18 19:15:00 UTC
Too bad I have not found this bug before message freeze. :-( However I am not sure about "format" either, as I suppose that pattern list get the same label too (probably also "All files"). (Unconfirming the wish, as it cannot be implemented anymore for KDE 3.5.) Have a nice day! On Saturday 17 September 2005 19:12, Nicolas Goutte wrote:
> However I am not sure about "format" either, as I suppose that pattern list
> get the same label too (probably also "All files").
Or "Type"?
Sounds good to me. Moving from "kio/kfile" component to "kfile" product, helps sorting out duplicates. "Filter" is the correct word, you can enter any string in the label (not necessarily a file type) and the view will be filtered accordingly. It's the correct term when there's a filter field. But in save dialogs which define a list of supported mimetypes that the file can be saved as, the text field disappears and becomes a combobox with file type options. In this case, "File format" or "File type" would be the correct string. Git commit f0668888660ffcbe578884c5e80cef53b16be50d by Nate Graham.
Committed on 06/05/2019 at 16:15.
Pushed by ngraham into branch 'master'.
[FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes
Summary:
The Filter combobox currently always has the label "Filter:" This is appropriate in most
cases, but becomes inaccurate when saving with a limited list of mimetypes. In this case,
the combobox loses its text field and becomes a file type chooser rather than a filter.
This patch changes the label to "File type:" for that use case.
FIXED-IN: 5.59
Test Plan:
Opening a file: no changes
{F6803789}
Saving a file with no mimetype filter: no changes
{F6803788}
Saving a file with a limited list of mimetypes: label is changed
{F6803790}
Reviewers: #vdg, elvisangelaccio, GB_2
Reviewed By: elvisangelaccio
Subscribers: pino, apol, kde-frameworks-devel
Tags: #frameworks
Maniphest Tasks: T8552
Differential Revision: https://phabricator.kde.org/D20964
M +34 -9 src/filewidgets/kfilewidget.cpp
https://commits.kde.org/kio/f0668888660ffcbe578884c5e80cef53b16be50d
|