Bug 79903

Summary: Wish: Replace technical term "Filter" with "File format" or "File type" when dialog displays a combobox of file types
Product: [Frameworks and Libraries] frameworks-kio Reporter: Dik Takken <kde>
Component: Open/save dialogsAssignee: David Faure <faure>
Status: RESOLVED FIXED    
Severity: wishlist CC: bfeber, bugseforuns, kdelibs-bugs, nate, nicolasg
Priority: NOR Keywords: junior-jobs, usability
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: https://commits.kde.org/kio/f0668888660ffcbe578884c5e80cef53b16be50d Version Fixed In: 5.59
Sentry Crash Report:

Description Dik Takken 2004-04-18 19:15:00 UTC 
Version:            (using KDE KDE 3.2.1)
Installed from:    Compiled From Sources
OS:          Linux

When I save a file from any application, I can choose to use a 'filter'. I think the term 'filter' is a bit strange for choosing a file format. Would the term 'format' not be more clear to the user?
Comment 1 Nicolas Goutte 2005-09-17 11:12:34 UTC 
Too bad I have not found this bug before message freeze. :-(

However I am not sure about "format" either, as I suppose that pattern list get the same label too (probably also "All files").

(Unconfirming the wish, as it cannot be implemented anymore for KDE 3.5.)

Have a nice day!
Comment 2 Clarence Dang 2005-09-17 13:02:09 UTC 
On Saturday 17 September 2005 19:12, Nicolas Goutte wrote:
> However I am not sure about "format" either, as I suppose that pattern list
> get the same label too (probably also "All files").


Or "Type"?
Comment 3 Dik Takken 2005-09-17 14:34:14 UTC 
Sounds good to me.
Comment 4 Christoph Feck 2009-08-27 02:35:21 UTC 
Moving from "kio/kfile" component to "kfile" product, helps sorting out duplicates.
Comment 5 Björn Feber 2019-05-01 16:49:45 UTC 
"Filter" is the correct word, you can enter any string in the label (not necessarily a file type) and the view will be filtered accordingly.
Comment 6 Nate Graham 2019-05-01 18:33:13 UTC 
It's the correct term when there's a filter field. But in save dialogs which define a list of supported mimetypes that the file can be saved as, the text field disappears and becomes a combobox with file type options. In this case, "File format" or "File type" would be the correct string.
Comment 7 Nate Graham 2019-05-02 14:52:39 UTC 
PatchL https://phabricator.kde.org/D20964
Comment 8 Nate Graham 2019-05-06 16:15:42 UTC 
Git commit f0668888660ffcbe578884c5e80cef53b16be50d by Nate Graham.
Committed on 06/05/2019 at 16:15.
Pushed by ngraham into branch 'master'.

[FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

Summary:
The Filter combobox currently always has the label "Filter:" This is appropriate in most
cases, but becomes inaccurate when saving with a limited list of mimetypes. In this case,
the combobox loses its text field and becomes a file type chooser rather than a filter.

This patch changes the label to "File type:" for that use case.
FIXED-IN: 5.59

Test Plan:
Opening a file: no changes
{F6803789}

Saving a file with no mimetype filter: no changes
{F6803788}

Saving a file with a limited list of mimetypes: label is changed
{F6803790}

Reviewers: #vdg, elvisangelaccio, GB_2

Reviewed By: elvisangelaccio

Subscribers: pino, apol, kde-frameworks-devel

Tags: #frameworks

Maniphest Tasks: T8552

Differential Revision: https://phabricator.kde.org/D20964

M  +34   -9    src/filewidgets/kfilewidget.cpp

https://commits.kde.org/kio/f0668888660ffcbe578884c5e80cef53b16be50d