Bug 79598

Summary:	debugging is forced on and should use kdebug instead
Product:	[Unmaintained] kpdf	Reporter:	Chris Cheney <ccheney>
Component:	general	Assignee:	Christophe Devriese <oelewapperke>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Chris Cheney 2004-04-13 23:40:47 UTC

Version:            (using KDE KDE 3.2.2)
Installed from:    Compiled From Sources
Compiler:          gcc 3.3.3 
OS:          Linux

kpdf uses its own macro called QPDFDBG instead of using kdebug. It also forces this macro on by default in the source and the only way to change it is via editting the source directly and recompiling. It should default to off at a minimum and should probably the kpdf should be modified to use kdebug instead since that allows easy configure switches to turn debugging on or off for the entire module.

Comment 1 Chris Cheney 2004-04-13 23:42:44 UTC

By the way the reason I found out about this problem is a Debian user filed a bug complaining about kpdf being so slow it was unusable. It had spit out over 4MB into the .xsession-errrors for a 4MB pdf file that they were trying to view.

http://bugs.debian.org/243187

Comment 2 Maksim Orlovich 2004-04-14 00:02:09 UTC

Please do not change priorities unless you're the maintainer

Comment 3 Albert Astals Cid 2004-04-23 22:47:44 UTC

CVS commit by aacid: 

Don't do forced debugging. Fixes half of 79598.
CCMAIL:79598@bugs.kde.org
CCMAIL:oelewapperke@wina.be


  M +2 -2      QOutputDev.cpp   1.15
  M +2 -2      QOutputDevPixmap.cpp   1.16


--- kdegraphics/kpdf/kpdf/QOutputDev.cpp  #1.14:1.15
@@ -60,6 +60,6 @@
 #include "QOutputDev.moc"
 
-#define QPDFDBG(x) x            // special debug mode
-//#define QPDFDBG(x)            // normal compilation
+//#define QPDFDBG(x) x          // special debug mode
+#define QPDFDBG(x)              // normal compilation
 
 //------------------------------------------------------------------------

--- kdegraphics/kpdf/kpdf/QOutputDevPixmap.cpp  #1.15:1.16
@@ -49,6 +49,6 @@
 #include "QOutputDevPixmap.moc"
 
-#define QPDFDBG(x) x            // special debug mode
-//#define QPDFDBG(x)            // normal compilation
+//#define QPDFDBG(x) x          // special debug mode
+#define QPDFDBG(x)              // normal compilation
 
 //------------------------------------------------------------------------

Comment 4 Albert Astals Cid 2004-08-25 23:47:43 UTC

QPDFDBG is gone