Bug 78912

Summary:	File->Open Crashes upon loading large a file in UMLClassifier::getOpList(bool)
Product:	[Applications] umbrello	Reporter:	Holger Lehmann <holger.lehmann>
Component:	general	Assignee:	Umbrello Development Group <umbrello-devel>
Status:	RESOLVED FIXED
Severity:	crash
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	XMI File to exploit the crash

Description Holger Lehmann 2004-04-02 15:17:53 UTC

Version:           1.2.90 (kdesdk-040402) (using KDE KDE 3.2.1)
Installed from:    Compiled From Sources
Compiler:          gcc 3.3 
OS:          Linux

I was editing a larger class having approx. 130 attributes.
There are two interfaces (couple of functions, around 15) and on more class without no attributes.
Along with this was a state diagram and approx. 20 use cases.
After saving the file, exiting umbrello, staring umbrello and reopening this file umrello just crashed.
This happened to the version (1.2.1) supplied in the KDE 3.2.1 RPMS for SuSE 8.2 as well as the sourcecode, version (1.2.90), from the kdesdk-040402.tar.bz2 file.

This is the traceback from the 1.2.90 version.
[New Thread 16384 (LWP 1902)]
0x4126bcf7 in waitpid () from /lib/libpthread.so.0
#0  0x4126bcf7 in waitpid () from /lib/libpthread.so.0
#1  0x40832cd9 in KCrash::defaultCrashHandler(int) ()
   from /opt/kde3/lib/libkdecore.so.4
#2  0x4126a895 in __pthread_sighandler () from /lib/libpthread.so.0
#3  <signal handler called>
#4  0x40ece570 in QGList::QGList(QGList const&) ()
   from /usr/lib/qt3/lib/libqt-mt.so.3
#5  0x080f3035 in UMLClassifier::getOpList(bool) ()
#6  0x0811f16d in InterfaceWidget::calculateAsConceptSize() ()
#7  0x0811f693 in InterfaceWidget::setShowOpSigs(bool) ()
#8  0x0811de34 in InterfaceWidget::init() ()
#9  0x0811dd3d in InterfaceWidget::InterfaceWidget(UMLView*, UMLInterface*) ()
#10 0x0817db42 in UMLView::loadWidgetFromXMI(QDomElement&) ()
#11 0x0817d2ed in UMLView::loadWidgetsFromXMI(QDomElement&) ()
#12 0x0817cbbd in UMLView::loadFromXMI(QDomElement&) ()
#13 0x0815a656 in UMLDoc::loadDiagramsFromXMI(QDomNode&) ()
#14 0x0815963b in UMLDoc::loadFromXMI(QIODevice&, short) ()
#15 0x08151223 in UMLDoc::openDocument(KURL const&, char const*) ()
#16 0x08148630 in UMLApp::openDocumentFile(KURL const&) ()
#17 0x08130671 in main ()
#18 0x413c28ae in __libc_start_main () from /lib/libc.so.6

Comment 1 Holger Lehmann 2004-04-02 15:24:40 UTC

Created attachment 5504 [details]
XMI File to exploit the crash

This is the file that will cause umbrello 1.2.1 and 1.2.90 to crash upon
loading.
Mark this, please: This file is copyrighted and the information contained
within is not for public use.

Comment 2 Oliver Kellogg 2004-04-09 23:32:11 UTC

Fixed in kdesdk/umbrello/umbrello/operation.cpp rev. 1.15.
The problem was caused by local generation of an ID for the
new attribute in UMLOperation::addParm(). The ID was in conflict
with another ID generated by UMLDoc::getUniqueID().

BTW, you can correct the XMI attachment by changing the xmi.id
to 200 (from the original value 123) in lines 604, 995, and 1478.