Bug 76269

Summary: Menu separators in Plastik theme are too short
Product: [Unmaintained] kdelibs Reporter: Jonathan Rawle <bugs.kde.org>
Component: kstyleAssignee: Sandro Giessl <sgiessl>
Status: RESOLVED FIXED    
Severity: wishlist    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: RedHat Enterprise Linux   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Jonathan Rawle 2004-02-27 13:41:18 UTC 
Version:            (using KDE KDE 3.2.0)
Installed from:    RedHat RPMs
OS:          Linux

The horizontal separators between groups of menu items are not long enough when the Plastik theme is selected.

The gap between the line and the edge of a menu is larger on the right hand side of the menu than on the left. These gaps should be equal. This is true of all menus, but the gap varies from one menu to another. The worst example is on the kmenu - the line below "Run Command..." has a very large gap to the right of it.

See, for example, the attachment accompanying Bug 75804. Notice the gaps on both visible menus, but worse on the main kmenu. I don't know whether this problem is related to the kmenu cut-off bug.

This only affects the Plastik theme.

Personally I would prefer the separating lines to extend across the whole width of the menu as in other themes. But at least there shouldn't be a larger gap on the right-hand side.
Comment 1 Sandro Giessl 2004-02-28 14:17:56 UTC 
CVS commit by giessl: 

oups.
CCMAIL: 76269-done@bugs.kde.org


  M +2 -2      plastik.cpp   1.61


--- kdeartwork/styles/plastik/plastik.cpp  #1.60:1.61
@@ -2299,7 +2299,7 @@ void PlastikStyle::drawControl(ControlEl
             {
                 p->setPen( cg.mid() );
-                p->drawLine( r.x()+5, r.y() + 1, r.width()-10, r.y() + 1 );
+                p->drawLine( r.x()+5, r.y() + 1, r.right()-5, r.y() + 1 );
                 p->setPen( cg.light() );
-                p->drawLine( r.x()+5, r.y() + 2, r.width()-10 , r.y() + 2 );
+                p->drawLine( r.x()+5, r.y() + 2, r.right()-5 , r.y() + 2 );
                 break;
             }