Bug 75737

Summary:	kget crash after click on pause, can download only one file, than stop and no go
Product:	[Applications] kget	Reporter:	Alex Kern <alex.kern>
Component:	general	Assignee:	KGet authors <kget>
Status:	RESOLVED DUPLICATE
Severity:	crash	CC:	rdieter
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Patch that correct probably many bugs more conservative solution

Description Alex Kern 2004-02-20 22:35:03 UTC

Version:            (using KDE KDE 3.2.0)
Installed from:    SuSE RPMs
Compiler:          installed from SuSE rpms 
OS:          Linux

kget has worked by me with 3.1.5. With latest 3.2 rpms from SuSE(18 dez 2004) it stops working. If download was
started before and interrupted, it not starts anymore. If a download not started before it can be completed. After it no any download can be started. You can shut app up, and start it again. Then you have new try.

Second error is crash, simply open kget window, select one item in list, click pause -> crash. In console you see signal 11. No core, no crashdump.

Comment 1 i.linty 2004-03-01 10:54:13 UTC

Created attachment 4954 [details]
Patch that correct probably many bugs

After many days of work I have found almost 3 bugs in the actual kget code
(0.8.3).
1) The Thread implementation is not safe ! Is not a good idea using
Qthread:terminate() and wait() for kill a thread ! I have correct this !
2) Sometimes You kill an FileCopyjob that is already been killed ! 
This cause: kget has recived signal 11 end It terminates !
3) When the download terminates, you kill the FileCopyjob! This is not safe !!!

This code correct the PAUSE-CRASH problem and probably many other bugs !
Can You test my code and verify if It can be usefull ?
Thank's for the attention.

I bag your pardon for my poor english !
Kind regards

Comment 2 Rex Dieter 2004-03-01 19:28:08 UTC

Appears to be a dup of bug #74596

Comment 3 Rex Dieter 2004-03-01 19:29:20 UTC

Sorry, I meant dup of #74597

Comment 4 Daniel Rendall 2004-03-01 19:59:26 UTC

OK, I hacked my Gentoo ebuild a little to rebuild the kdenetwork-3.2.0 package with the attached patch (4954).

First indications look good - it's happily downloaded 8 files successfully so far. Previously I'd have been lucky to get 1, or even to have the program start up at all without hanging.

I guess you should get more confirmation but I reckon that you've fixed it :-)

Comment 5 Alex Kern 2004-03-03 20:13:29 UTC

Created attachment 5005 [details]
more conservative solution

hi, give a try

Comment 6 Daniel Rendall 2004-03-03 23:00:33 UTC

I tried the latest patch (5005) but it was rejected:

***** kget_patch_5005.txt *****

===============================

PATCH COMMAND:  patch  -p0 < /usr/portage/kde-base/kdenetwork/files/kget_patch_5005.txt

===============================
patching file kget/slave.cpp
Hunk #1 succeeded at 109 with fuzz 1.
Hunk #2 FAILED at 125.
Hunk #3 succeeded at 143 (offset -2 lines).
Hunk #4 FAILED at 242.
2 out of 4 hunks FAILED -- saving rejects to file kget/slave.cpp.rej
===============================

I can't find the file kget/slave.cpp.rej in the build directory or anywhere else sensible.

Version of slave.cpp (from the current kdenetwork-3.2.0 Gentoo package) I'm using is:

Revision     : $Id: slave.cpp,v 1.20 2003/03/03 15:34:46 pfeiffer Exp $

Sorry! If you can do me a patch against that version, I'll give it a go.

Comment 7 Aaron Scruggs 2004-03-04 06:56:59 UTC

I was having the same problem.   Patched with kget_patch_5005.  Now seems to 
work.

Comment 8 Alex Kern 2004-03-06 23:30:33 UTC

OK, I can commit, I have a license for it ;-), which patch? Any suggestions?
Voting?

Regards Alex
P.S. I think, it's a bit too late for 3.2.1. Sorry guys.

Comment 9 Rex Dieter 2004-03-10 17:22:20 UTC


*** This bug has been marked as a duplicate of 74597 ***