| Summary: | [PATCH] bad session management when KMail is minimized to tray | ||
|---|---|---|---|
| Product: | [Unmaintained] kmail | Reporter: | Olivier Fisette <olivier.fisette> |
| Component: | general | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aliakc, jlp, khanreaper, winter |
| Priority: | NOR | Keywords: | triaged |
| Version: | 1.10.90 | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Make kmail start hidden if restored by session manager
Restore kmail hidden at session startup if it was hidden Simpler version of the previous patch |
||
|
Description
Olivier Fisette
2004-02-20 03:39:23 UTC
Similar problem for me, user defined save session used by ksmserver doesn't work if kmail is minimized to tray. It does work if you save the session when kmail is not minimized, then it is restored as it should. I can't confirm the lockfile issue for my installation (Debian unstable, KDE 3.2.2, kmail 1.6.2). Could you check with kde 3.3 ? I can not reproduce this anymore. I'll close this report for now, please reopen if it still happens. It does work now, partly. The session is restored, including kmail, but kmail is started maximized, even if it was minimized during session saving. So the bug reports' title should change from "No or bad session management when KMail is minimized to tray" to "bad session management when KMail is minimized to tray". So maybe you should reopen it (I can't, as I'm not the reporter). as requested *** Bug 90919 has been marked as a duplicate of this bug. *** *** This bug has been confirmed by popular vote. *** I can confirm that this still happens with KDE 3.4.1. This also happens with KDE 3.4.2 Any possibility that this will be fixed? KDE 3.5.1 and still not fixed!! KOrganizer tray module is exactly what I want. Click on the tray item -> one can choose wheather you want to start it on startup or not. If selected it starts minimized to the tray. Hi, I am also having problems with this feature. KMail is refusing to start minimised to the tray. At the moment I have implemented it by changing the KMail icon to run the following command: "kmail;dcop kmail kmail-mainwindow#1 hide" This runs KMail, and then sends a message via DCOP to hide the main window to the system tray. I hope this helps until this feature is implemented properly :) Regards, Aaron I've checked this with KMail from KDE SVN r881890 (to be in KDE 4.2) and KMail doesn't start minimized to tray, it's maximized. Created attachment 31876 [details]
Make kmail start hidden if restored by session manager
> Make kmail start hidden if restored by session manager
Well, if I had KMail maximized before shutdown, I still want to have it maximized when the session is restored. That is not handled by the patch, right?
Can you add that to the patch? Either remember the shown/hidden state in KMail or in KMainWin (probably needs a new restore() method for compatibilty then).
If the patch is ready, please submit it to reviewboard.kde.org, under the "kdepim" group.
Thanks.
Created attachment 32542 [details]
Restore kmail hidden at session startup if it was hidden
Indeed kmail never got restored with the previous patch.
This one should do the trick with a ->restore override and
session state save/restore copied and adapted from aKregator.
Appreciate it if you would post this to our new patch review system on reviewboard.kde.org under the kdepim group. This is where we now collect and review patches. Created attachment 32554 [details] Simpler version of the previous patch Simpler version attached, reviewboard thingy at: http://reviewboard.kde.org/r/504/ Should I try and keep bgo in sync with reviewboard if this goes anywhere? I'm not sure I understand the process/workflow. > Should I try and keep bgo in sync with reviewboard if this goes anywhere?
> I'm not sure I understand the process/workflow.
No need.
The workflow will continue on reviewboard.
SVN commit 951220 by tmcguire: Remember the docked state for session management. Patch by Mathieu Seigneurin <matsei@seimat.net>, thanks! BUG: 75673 M +19 -0 kmmainwin.cpp M +9 -0 kmmainwin.h WebSVN link: http://websvn.kde.org/?view=rev&revision=951220 SVN commit 953503 by tmcguire: Backport r951220 by tmcguire from trunk to the 4.2 branch: Remember the docked state for session management. Patch by Mathieu Seigneurin <matsei@seimat.net>, thanks! CCBUG: 75673 M +19 -0 kmmainwin.cpp M +9 -0 kmmainwin.h WebSVN link: http://websvn.kde.org/?view=rev&revision=953503 |