Bug 75269

Summary:	JJ: Changing XSLT style in RTL mode switches HTML in open chats to LTR
Product:	[Unmaintained] kopete	Reporter:	Martijn Klingens <klingens>
Component:	Chatwindow Styles	Assignee:	Kopete Developers <kopete-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	0.8.0
Target Milestone:	---
Platform:	unspecified
OS:	All
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Martijn Klingens 2004-02-15 11:59:03 UTC

Version:            (using KDE Devel)
Installed from:    Compiled sources

Nice one for Jason...

While trying to look into #67698 I noticed that switching the XSLT style doesn't correctly update open chat windows when using --reverse (RTL mode).

Not too surprising after looking in the code, since only addChatMessage() takes the RTL into account by adding a <span> around the resulting HTML.

I think that span should not be created in C++, but instead be part of the XSLT engine, by passing the reverseLayout() value as parameter. Whether the XSLT should be added to all styles or just added by the engine in a generic way I don't know. The latter sounds cleaner, but not sure if it's possible.

Either way, Jason, could you take care of this one?

Martijn

Comment 1 Richard Smith 2004-07-31 01:00:14 UTC

Should be easy enough for a beginner to track down the two code paths and unify them somewhat.

Comment 2 Michaël Larouche 2006-04-15 16:43:33 UTC

XSLT engine was replaced in 0.12, and take care of Bidi.