Bug 75175

Summary: sometimes the kde wallet question window is started in the background.
Product: [Plasma] kwin Reporter: sts
Component: generalAssignee: Lubos Lunak <l.lunak>
Status: RESOLVED FIXED    
Severity: major CC: alexandertruemper, geroxp, p92, sorn73
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description sts 2004-02-13 20:14:07 UTC
Version:           1.0 (using KDE 3.2.0, SuSE)
Compiler:          gcc version 3.3.1 (SuSE Linux)
OS:          Linux (i686) release 2.4.21-166-default

sometimes the kde wallet question window is started in the background.

IMHO It's not very user friendly. It should be always indicated in highest place, if the pertinent window is active.
Comment 1 Lubos Lunak 2004-02-16 13:09:00 UTC
*** Bug 74524 has been marked as a duplicate of this bug. ***
Comment 2 Lubos Lunak 2004-02-23 14:01:21 UTC
There was a small problem caused by a change in Qt3.3.
Comment 3 Lubos Lunak 2004-03-06 14:46:17 UTC
*** Bug 76847 has been marked as a duplicate of this bug. ***
Comment 4 Thibaut Cousin 2004-03-14 21:57:48 UTC
The bug is marked as fixed, but in KDE 3.2.1 with Qt 3.3.1 the problem is still there. For example, the password prompt dialog is always hidden by the Kontact  window when I launch Kontact with the KNode module (because the KNode module asks for the password on startup).

If the bug was fixed only in HEAD, it's worth a backport because I saw some end-user completely lost by that.

Thanks for your attention!
Comment 5 S. Burmeister 2004-07-05 16:35:32 UTC
Hi,

I do not know if this is the bug that is mentioned in the KDE 3.2.3 release notes:  Keep KWallet's password dialog above other windows

If so, one should add that not only the password-window should be raised but also the dialogue that asks whether an application is allowed to get access to kwallet once, always or to cancel the request. This window is still kept in the background.
Comment 6 John Myers 2005-04-23 18:22:31 UTC
I would like to vote for reopening this bug. In fact, it should be more than raised. It should be raised, focused, and placed on all desktops. Also, when it _does_ pop up, it needs to have (and keep) the keyboard focus. I have kmail and kopete in my session, so when I log in, it asks me for my kwallet password. However, I usually also have a konsole or kate window in my session. When KWallet comes up, it doesn't get the focus. I see the box and start typing ... into a clear text field. This, IMHO, is a Bad Thing(tm).
Comment 7 John Myers 2005-04-23 18:23:12 UTC
Oh, yeah, I forgot to mention, I'm on KDE 3.4
Comment 8 Chase Venters 2005-07-16 03:20:51 UTC
Agreed. In 3.4, the window does not take keyboard focus when composing e-mail with KMail. Bug should be re-opened.
Comment 9 p92 2005-07-16 16:16:38 UTC
same for 3.4.1 ! the password entry window is visible but does not have the focus automatically
Comment 10 Andrew Kohlsmith 2005-10-07 14:34:55 UTC
This is happenning again in 3.5beta1.  I was also doing it in 3.4.2.  pinentry-qt works perfectly (steals focus with extreme prejudice) but kwallet's password entry just comes to the top of hte window stack... it does NOT steal keyboard focus and it should.  I have on more than one occassion almost typed my password into an IRC session.
Comment 11 Andrew Kohlsmith 2005-10-07 14:35:41 UTC
*** Bug 109540 has been marked as a duplicate of this bug. ***
Comment 12 Jonas Fährmann 2005-12-15 16:40:06 UTC
Inapropriate focus is a general annoyance with most kde password dialogs. I once even mailed my gpg matra to a stranger before noticing what happened, and I was lucky enough to notice it at all IMHO.
Comment 13 Lubos Lunak 2006-01-20 16:46:11 UTC
SVN commit 500572 by lunakl:

When updating a user timestamp of a window, also always update timestamp
of the whole group.
BUG: 75175



 M  +1 -0      activation.cpp  
 M  +3 -0      manage.cpp  


--- branches/KDE/3.5/kdebase/kwin/activation.cpp #500571:500572
@@ -637,6 +637,7 @@
         && ( user_time == CurrentTime
             || timestampCompare( time, user_time ) > 0 )) // time > user_time
         user_time = time;
+    group()->updateUserTime( user_time );
     }
 
 Time Client::readUserCreationTime() const
--- branches/KDE/3.5/kdebase/kwin/manage.cpp #500571:500572
@@ -23,6 +23,7 @@
 
 #include "notifications.h"
 #include "rules.h"
+#include "group.h"
 
 extern Time qt_x_time;
 
@@ -422,7 +423,9 @@
     // - keep it?
     XLowerWindow( qt_xdisplay(), frameId());
 
+    // set initial user time directly
     user_time = readUserTimeMapTimestamp( asn_valid ? &asn_id : NULL, asn_valid ? &asn_data : NULL, session );
+    group()->updateUserTime( user_time ); // and do what Client::updateUserTime() does
 
     if( isTopMenu()) // they're shown in Workspace::addClient() if their mainwindow
         hideClient( true ); // is the active one