Bug 74329

Summary: second <body> tag overrides colors for the whole document
Product: [Applications] konqueror Reporter: Alexander Bussman <buxman>
Component: khtml parsingAssignee: Konqueror Developers <konq-bugs>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: RedHat Enterprise Linux   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Alexander Bussman 2004-02-06 11:11:26 UTC 
Version:           3.2.0 (using KDE KDE 3.2.0)
Installed from:    RedHat RPMs
Compiler:          3.3.2 (Red Hat Linux 3.3.2-1)
OS:          Linux

http://www.cygwin.com does not view very well with konqueror, if you go to that site I guess you know what I mean.
Comment 1 Stephan Kulow 2004-02-06 11:40:12 UTC 
Subject: Re:  New: Webpage does not view correctly

On Friday 06 February 2004 11:11, Alexander Bussman wrote:
> http://www.cygwin.com does not view very well with konqueror, if you go to that site I guess you know what I mean.
> 
Well, that page got two body tags:

<body bgcolor="#000000" color="#000000" link="#000000" vlink="#000000" alink="#000000"><p>
<font size=-1 color="white"><em>DO NOT SEND EMAIL TO THIS ADDRESS <a
href="mailto:aaaspam@sources.redhat.com"
color="white"></a>aaaspam@sources.redhat.com IT IS HERE ONLY TO COLLECT
SPAM.  IF YOU SEND EMAIL TO THIS ADDRESS YOU WILL BE AUTOMATICALLY
BLOCKED.  </em></body>

Greetings, Stephan
Comment 2 Alexander Bussman 2004-02-06 11:52:09 UTC 
hmmm, strange that other browsers can view it :/
Comment 3 Stephan Kulow 2004-02-06 13:10:48 UTC 
they reimplemented ns4 bugs better ;(
Comment 4 Dirk Mueller 2004-02-10 15:04:03 UTC 
CVS commit by mueller: 

CCMAIL: 74329-done@bugs.kde.org


  M +4 -0      ChangeLog   1.201
  M +4 -2      html/htmlparser.cpp   1.346


--- kdelibs/khtml/ChangeLog  #1.200:1.201
@@ -1,2 +1,6 @@
+2004-02-10  Dirk Mueller  <mueller@kde.org>
+
+        * html/htmlparser.cpp (insertNode): argh. regression fix (http://www.cygwin.com) (#74329).
+
 2004-02-09  David Faure  <faure@kde.org>
 

--- kdelibs/khtml/html/htmlparser.cpp  #1.345:1.346
@@ -446,6 +446,8 @@ bool KHTMLParser::insertNode(NodeImpl *n
                     NodeImpl::Id attrId = map->idAt(l);
                     DOMStringImpl *attrValue = map->valueAt(l);
-                    changed = !bmap->getValue(attrId);
+                    if ( !bmap->getValue(attrId) ) {
                     bmap->setValue(attrId,attrValue);
+                        changed = true;
+                    }
                 }
                 if ( changed )