Bug 73676

Summary:	Keyboard shortcut for "Add to Addressbook" takes wrong address
Product:	[Applications] kmail2	Reporter:	Cornelius Schumacher <schumacher>
Component:	commands and actions	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jtamate, montel
Priority:	NOR	Keywords:	triaged
Version First Reported In:	Git (master)
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Cornelius Schumacher 2004-01-28 13:48:07 UTC

Version:            (using KDE Devel)
Installed from:    Compiled sources
OS:          Linux

Assign a keyboard shortcut to the "Add to Addressbook" action and use that to add an entry to the addressbook. Then go to another mail and use the keyboard shortcut again. An error message appears that the contact already is in the addressbook. Go to another mail and the same error message appears again.

The problem seems to be that when using the keyboard shortcut the context information to determine which address should be added is missing.

I see two possible solutions to the problem, either prevent the "Add to Addressbook" being assigned a keyboard shortcut or show a dialog where all email addresses of the currently visible mail are listed and the user can select which are to be added.

Comment 1 Ingo Klöcker 2004-01-28 14:14:09 UTC

I order to prevent the action to be listed in the shortcut config we would probably have to use a second actioncollection. Not very clean IMO. I like the second idea better.

Comment 2 Jaime Torres 2008-09-09 18:09:00 UTC

I've been able to reproduce the error following the steps in the bug report using kmail 1.10.1.

Comment 3 Christophe Marin 2012-01-08 21:04:27 UTC

Valid in master

- Settings / Configure shortcuts
- Assign a shortcut for "Add to address book"
- Select a message,
- Use the shortcut.

The wrong address is added to the addressbook

Comment 4 Laurent Montel 2012-02-08 11:08:19 UTC

I confirm it. Will look at.

Comment 5 Laurent Montel 2012-02-08 11:51:21 UTC

I fixed url when we change message.
I clear it so we can't save bad url.

But for me we must forbid to add shortcut for this action because it's the last url clicked.
So if we click on a http url in message it will store it in addressbook.

It's not a good idea.

Or we can store CC/BCC/To address and we can't specify it with shortcut.

I vote to forbid to add shortcut to this action.

Comment 6 Laurent Montel 2012-02-08 12:54:49 UTC

 Now we can't add shortcut for these actions.
Regards