Bug 73095

Summary:	no overwrite option when moving files and directories
Product:	[Applications] konqueror	Reporter:	John Miller <neuromancerx1>
Component:	general	Assignee:	Konqueror Bugs <konqueror-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	phoenixg
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description John Miller 2004-01-21 01:48:23 UTC

Version:           3.2.0 (using KDE 3.2.0 RC1, compiled sources)
Compiler:          gcc version 3.3.1 (Mandrake Linux 9.2 3.3.1-2mdk)
OS:          Linux (i686) release 2.4.22-21mm.1mdk

When choosing 'move' from the right-click menu you only get the choice to 'rename' or 'cancel' if the file or directory already exists, no 'overwrite' or 'overwrite all'.
If you choose 'copy' instead of 'move' then the 'overwrite' and 'overwrite all' options do appear in the dialog.

Comment 1 Kai Lahmann 2004-01-21 02:28:49 UTC

2 weeks old CVS here - there it works.

Comment 2 Pascal Létourneau 2004-01-24 21:59:51 UTC

Subject: kdelibs/kio/kio

CVS commit by pletourn: 

Give the choice <Overwrite> when moving files.
CCMAIL:73095-done@bugs.kde.org


  M +3 -1      job.cpp   1.369


--- kdelibs/kio/kio/job.cpp  #1.368:1.369
@@ -3064,8 +3064,10 @@ void CopyJob::slotResult( Job *job )
             if ( err )
             {
+                bool renaming = ( m_currentSrcURL.directory() == m_dest.directory() );
                 m_currentSrcURL=*m_currentStatSrc;
                 m_currentDestURL=m_dest;
 
-                if ( err == ERR_DIR_ALREADY_EXIST || err == ERR_FILE_ALREADY_EXIST )
+                if ( ( err == ERR_DIR_ALREADY_EXIST || err == ERR_FILE_ALREADY_EXIST ) && 
+                     renaming )
                 {
                     if (m_reportTimer)

Comment 3 David Faure 2004-03-21 22:42:23 UTC

*** Bug 77772 has been marked as a duplicate of this bug. ***