Bug 72775

Created attachment 4198 [details]
part of my ~/.xsession_errors that shows the problem

You can see that an assertion is triggered.

kmail: render_block.cpp:426: void khtml::RenderBlock::layoutBlock(bool): Assertion `false' failed.

Would you mind updating? I believe this code has been recently changed.

Subject: Re:  CRASH: printing message in draftfolder

On Friday 16 January 2004 19:57, Thiago Macieira wrote:
> ------- You are receiving this mail because: -------
> You reported the bug, or are watching the reporter.
> You are a voter for the bug, or are watching someone who is.
>
> http://bugs.kde.org/show_bug.cgi?id=72775
> thiagom@mail.com changed:
>
>            What    |Removed                     |Added
> ---------------------------------------------------------------------------
>- AssignedTo|kmail-devel@kde.org         |konq-bugs@kde.org
> Component|general                     |khtml renderer
>             Product|kmail                       |konqueror
>
>
>
> ------- Additional Comments From thiagom@mail.com  2004-01-16 19:57 -------
> kmail: render_block.cpp:426: void khtml::RenderBlock::layoutBlock(bool):
> Assertion `false' failed.
>
> Would you mind updating? I believe this code has been recently changed.

I don't mind updating at all.

But I have to wait a few days before Mandrake builds new RPMs. For some
reason they do not build the network part as often as the base part of
KDE.
So probably I can only test this again after 3.2 is frozen...

that's very strange actually. But as a matter of fact, it's the same crash

*** This bug has been marked as a duplicate of 65715 ***

*** Bug 73273 has been marked as a duplicate of this bug. ***

*** Bug 73325 has been marked as a duplicate of this bug. ***

the assert got nothing to do with the other one

*** Bug 73169 has been marked as a duplicate of this bug. ***

Subject: kdelibs/khtml

CVS commit by mueller: 

* rendering/render_canvas.cpp (layout): don't recurse when printing (#72775).
CCMAIL: 72775-done@bugs.kde.org


  M +2 -0      ChangeLog   1.183
  M +18 -16    rendering/render_canvas.cpp   1.145


--- kdelibs/khtml/ChangeLog  #1.182:1.183
@@ -1,4 +1,6 @@
 2004-01-25  Dirk Mueller  <mueller@kde.org>
 
+        * rendering/render_canvas.cpp (layout): don't recurse when printing (#72775).
+
         * rendering/render_image.cpp (setPixmap): handle cases when
         we're not inserted in the tree yet, but the image is already loaded

--- kdelibs/khtml/rendering/render_canvas.cpp  #1.144:1.145
@@ -141,4 +142,7 @@ void RenderCanvas::layout()
     qt.start();
 #endif
+    KHTMLView::ScrollBarMode vsmode = m_view->vScrollBarMode();
+    KHTMLView::ScrollBarMode hsmode = m_view->hScrollBarMode();
+
     if (!m_printingMode) {
         QSize s = m_view->viewportSize(m_view->contentsWidth(),
@@ -146,12 +150,4 @@ void RenderCanvas::layout()
         m_viewportWidth = m_width = s.width();
         m_viewportHeight = m_height = s.height();
-    }
-    else {
-        m_width = m_rootWidth;
-        m_height = m_rootHeight;
-    }
-    
-    KHTMLView::ScrollBarMode vsmode = m_view->vScrollBarMode();
-    KHTMLView::ScrollBarMode hsmode = m_view->hScrollBarMode();
     
     if (m_view->verticalScrollBar()->isVisible())
@@ -164,5 +160,9 @@ void RenderCanvas::layout()
     else
         m_view->setHScrollBarMode(KHTMLView::AlwaysOff);
-
+    }
+    else {
+        m_width = m_rootWidth;
+        m_height = m_rootHeight;
+    }
 
     RenderBlock::layout();
@@ -191,6 +191,8 @@ void RenderCanvas::layout()
     layer()->resize( kMax( docW,int( m_width ) ), kMax( docH,m_height ) );
 
-    m_view->setVScrollBarMode(vsmode);
+    if ( !m_printingMode ) {
     m_view->setHScrollBarMode(hsmode);
+        m_view->setVScrollBarMode(vsmode);
+    }
 
     setLayouted();

My kmail 3.2.0 (the release) also crashes consistently when I hit print in the print requestor. This is a linux Fedora 1 with kernel 2.6.1 and Qt 2.3.2 all compiled from source. As far as I can tell all other KDE programs prnt ok. I use CUPS 1.1.19-13 from RPM.

Hi All,

I too have this probelm with Kmail 1.6 & KDE 3.2 compiled from source. Printing any e-mail, HTML or plain text triggers this Assert (from .xsession-errors)

kmail: render_block.cpp:426: void khtml::RenderBlock::layoutBlock(bool): Assertion `false' failed.

QT version 3.2.1 (Source)
CUPS 1.1.14-1 (Debian binary)

*** Bug 74728 has been marked as a duplicate of this bug. ***

is there a patch or something around i can use? 

i tried the cvs-commit from Comment #9 but it will not work as patchfile ... can anyone make a patchfile from it, please?

thank you in advance, this bug is really anoying, because so, you cannot print out of kmail in any way