Bug 72701

Summary:	Wish: Option: Always opened bars (ToolBar,LocationBar,StatusBar) even if javascripts tries to close them
Product:	[Applications] konqueror	Reporter:	Gilhad <gilhad>
Component:	general	Assignee:	Konqueror Bugs <konqueror-bugs-null>
Status:	REOPENED ---
Severity:	wishlist	CC:	aristsakas, gschintgen, luigi.toscano
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	RedHat Enterprise Linux
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Status/main/tools ... bars never disappers because of web page/javascript. Still able to close them manually The same hack for 3.3.1

Description Gilhad 2004-01-15 17:54:25 UTC

Version:            (using KDE KDE 3.1)
Installed from:    RedHat RPMs
OS:          Linux

I want to have always opened some bars (ToolBar,LocationBar,StatusBar), no matter, what the web page is trying.
I use to browse web with DISABLED "always open images" because this is faster and most of pages look good this way for me. (I am browsing mainly information pages, where images are NOT important and navigation work good without them). 
But some of webs (where I go for images) have only thumbnails and opens images via javascript in new html-based window WITHOUT bars.
So I have to right-click for "Show menu bar", then click for "Show toolbar" then click for "Display images on Page". For every picture again and again. Terrible. (And I need to reanable LocationBar after leaving such site) I do not care, what author of such pages prefere in his/her browser, but I want my browser looks everytime the same way, even if it means, that someones artistic vision is not fullfilled. 

Also I like the StatusBar, where I can see, where the link leads, without clicking it. If it will be possible, I will like restriction on Javascripts such this:
Enable Javascript to affect *Bars: NO
Enable Javascript to hide info on target location: NO 
(means Status function, which writes to statusBar)
Show Form target: YES ( [form action="something"]...)

Maybe in config-file only, but I pretty-pretty please you for such options.

Comment 1 Gilhad 2004-06-24 18:43:02 UTC

For those, who want THIS functionality - I hacked it for myself as here:
(the hack consists in 3 blocks commented out /* %%% .... %%% */ )
# pwd
/var/tmp/portage/kdebase-3.2.2/work/kdebase-3.2.2/konqueror
# diff  konq_mainwindow.cc.old konq_mainwindow.cc  -C 3
*** konq_mainwindow.cc.old      Thu Jun 24 18:27:44 2004
--- konq_mainwindow.cc  Thu Jun 10 15:26:03 2004
***************
*** 1127,1132 ****
--- 1127,1133 ----
      mainWindow->resize( width, height );
  
      // process the window args
+ /* %%%
      if ( !windowArgs.menuBarVisible )
      {
          mainWindow->menuBar()->hide();
***************
*** 1147,1152 ****
--- 1148,1154 ----
      if ( !windowArgs.resizable )
          // ### this doesn't seem to work :-(
          mainWindow->setSizePolicy( QSizePolicy( QSizePolicy::Fixed, QSizePolicy::Fixed ) );
+ %%% */
  // Trying to show the window initially behind the current window is a bit tricky,
  // as this involves the window manager, which may see things differently.
  // Many WMs raise and activate new windows, which means without WM support this won't work very
***************
*** 1155,1160 ****
--- 1157,1163 ----
      bool wm_usertime_support = false;
      extern Time qt_x_user_time;
      Time saved_last_input_time = qt_x_user_time;
+  /* %%%
      if ( windowArgs.lowerWindow )
      {
          NETRootInfo wm_info( qt_xdisplay(), NET::Supported );
***************
*** 1172,1178 ****
--- 1175,1183 ----
          mainWindow->lower();
          mainWindow->stackUnder( this );
      }
+ %%% */
      mainWindow->show();
+ /* %%%
      if ( windowArgs.lowerWindow )
      {
          qt_x_user_time = saved_last_input_time;
***************
*** 1184,1189 ****
--- 1189,1195 ----
                  this->setActiveWindow();
          }
      }
+ %%% */
      if ( windowArgs.fullscreen )
          mainWindow->action( "fullscreen" )->activate();
  }

Comment 2 Gilhad 2004-06-24 18:44:08 UTC

It works for me now, and I am happy ;-)

Comment 3 Gilhad 2004-08-04 10:56:57 UTC

Created attachment 6990 [details]
Status/main/tools ... bars never disappers because of web page/javascript. Still able to close them manually

My solution to this problem on 3.2.3 version

Comment 4 Gilhad 2004-11-11 13:07:27 UTC

Created attachment 8249 [details]
The same hack for 3.3.1

Status/main/tools ... bars never disappers because of web page/javascript.
Still able to close them manually.
Small ugly hack by commenting out part of code.

Comment 5 Dirk Stoecker 2006-08-29 18:18:56 UTC

If you could add the proper configuration settings this patch could be applied. E.G. Adding a setting like "Never hide control elements" would do the trick.

BTW: When using tabs and auto-open popups/new windows in tabs you also get the desired behaviour.