Bug 72528

Summary:	[test case] missdirection when numbers is in RTL test
Product:	[Applications] konqueror	Reporter:	Arash Bijanzadeh <a.bijanzadeh>
Component:	khtml renderer	Assignee:	Konqueror Developers <konq-bugs>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	A sample of what is happening Test Case

Description Arash Bijanzadeh 2004-01-13 07:59:39 UTC

Version:            (using KDE KDE 3.1.94)
Installed from:    Compiled From Sources
Compiler:          gcc 3.3.1 
OS:          Linux

When English numbers apear in the html among the RTL charachters -Farsi for example- The rest of the line changes the direection to LTR and the charachters are messing up

Comment 1 Arash Bijanzadeh 2004-01-13 08:05:29 UTC

Created attachment 4134 [details]
A sample of what is happening

Hard to tell when this is happening really. The snapshot taken from
www.technotux.com the marked area is infeted with the bug. charachters arranged
fro left to right, which supposed to be right to left.

Comment 2 Stephan Kulow 2004-01-27 16:30:32 UTC

we still need a test case. a screenshot isn't enough

Comment 3 Arash Bijanzadeh 2004-01-28 14:05:09 UTC

Created attachment 4395 [details]
Test Case

The Bug is related to the decimal point.  When a decimaal point's in the RTL
context KHTML renders it in a wrong direction. I think the attached html file
would be enough for testing.

Comment 4 Diego Iastrubni 2004-04-16 00:07:06 UTC

I cannot reproduce it with hebrew. Funny.

BTW: the arabic shaping is not working here. I get AA fonts, but no shaping. Using he_IL.UTF8 and I have the arabic-ttf fonts installed on a Mandrake 9.2 (XFree86 4.3). QT 3.3.1 and KDE 3.2.2 from cvs.

Comment 5 Allan Sandfeld 2004-12-06 18:54:00 UTC

CVS commit by carewolf: 

Small change to fix numbers with decimal point in RTL text.
BUG:72528


  M +7 -2      ChangeLog   1.348
  M +1 -1      rendering/bidi.cpp   1.203


--- kdelibs/khtml/ChangeLog  #1.347:1.348
@@ -1,11 +1,16 @@
+2004-12-06  Allan Sandfeld Jensen <kde@carewolf.com>
+
+        * rendering/bidi.cpp: Layout arabic numbers with a separator correctly.
+
 2004-12-02  Allan Sandfeld Jensen <kde@carewolf.com>
+
         Implement remaining CSS2 list-style-types and a few CSS3
 
-        * render/render_list.cpp: New algorithms for hiragana, katakana,
+        * rendering/render_list.cpp: New algorithms for hiragana, katakana,
             armenian, georgian and decimal-leading-zero.
             Also fix greek and latin list-styles for larger values.
         * css/cssvalues.cpp: Parse box, -khtml-diamond, -khtml-arabic-indic,
             -khtml-persian, -khtml-urdu and -khtml-upper-greek
-        * render/render_style.h: Expand list-style enum
+        * rendering/render_style.h: Expand list-style enum
 
 2004-11-30  Germain Garand  <germain@ebooksfrance.org>

--- kdelibs/khtml/rendering/bidi.cpp  #1.202:1.203
@@ -1018,5 +1018,5 @@ void RenderBlock::bidiReorderLine(const 
                 case QChar::DirCS:
                     if(bidi.status.eor == QChar::DirAN) {
-                        bidi.eor = bidi.current; bidi.status.eor = QChar::DirR; break;
+                        bidi.eor = bidi.current; break;
                     }
                 case QChar::DirES: