Bug 72490

Summary: KWallet stores, but does not allow connections when retrieving from kwallet.
Product: [Unmaintained] kopete Reporter: Cal Goodman <cal-kopete>
Component: libkopeteAssignee: Kopete Developers <kopete-bugs-null>
Status: RESOLVED FIXED    
Severity: major CC: cvanwijk, frederic, heinrich.wendel
Priority: NOR    
Version: 0.8.0   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: Set rememberPassword before saving the config
New try

Description Cal Goodman 2004-01-12 17:40:40 UTC
Version:           unknown (using KDE 3.1.94 (3.2 Beta 2), Gentoo)
Compiler:          gcc version 3.2.3 20030422 (Gentoo Linux 1.4 3.2.3-r2, propolice)
OS:          Linux (i686) release 2.4.20-gentoo-r7

Upon startup of kopete cvs, it asks for ICQ/MSN/etc passwords.  Upon entry of those passwords, it stores them successfully into kwallet (verified through kwallet).

Kopete then fails to create its connections at all.  Does not even try and fail with a password.

Deleting the kwallet entries and disconnecting kopete from the wallet, kopete asks to store the passwords 'unsafe'.  It can successfully connect to networks.  However, on restart of kopete, it asks for passwords all over again.  It seems that these values were not stored to disk at all either.  Back to square one.
Comment 1 Martijn Klingens 2004-01-17 17:40:12 UTC
The problem is that the config is saved before the rememberPassword flag is processed... will attach a patch.

Martijn
Comment 2 Martijn Klingens 2004-01-17 17:49:09 UTC
Created attachment 4210 [details]
Set rememberPassword before saving the config

Please review. I can't commit myself because my local version of the file has
tons of other stuff, so someone else should commit after review.

I consider this a showstopper for KDE 3.2 btw, so feel free to commit now.

Martijn
Comment 3 Andy Goossens 2004-01-17 17:59:34 UTC
Martijn: and now a *real* patch please? :-)
Comment 4 Martijn Klingens 2004-01-17 18:23:00 UTC
*** Bug 69239 has been marked as a duplicate of this bug. ***
Comment 5 Martijn Klingens 2004-01-17 18:24:26 UTC
Created attachment 4212 [details]
New try

What the $@$@#$%@#$ is KHTML doing with my patch?

Trying again.
Comment 6 Olivier Goffart 2004-01-17 22:35:19 UTC
Subject: KDE_3_2_BRANCH: kdenetwork/kopete/libkopete

CVS commit by ogoffart: 

Martijn's patch to fix the major bug 72490

CCMAIL: 72490-done@bugs.kde.org

Can someone commit it on HEAD? thanks


  M +3 -3      kopeteaccount.cpp   1.78.2.1


--- kdenetwork/kopete/libkopete/kopeteaccount.cpp  #1.78:1.78.2.1
@@ -327,9 +327,9 @@ QString KopeteAccount::password( bool er
         if ( passwdDialog->exec() == QDialog::Accepted )
         {
-                pass = view->m_password->text();
-                if ( view->m_save_passwd->isChecked() )
-                        setPassword( pass );
                 d->rememberPassword = view->m_save_passwd->isChecked();
                 d->autologin = view->m_autologin->isChecked();
+                pass = view->m_password->text();
+                if ( d->rememberPassword )
+                        setPassword( pass );
         }
         else


Comment 7 Martijn Klingens 2004-01-20 20:03:23 UTC
*** Bug 73036 has been marked as a duplicate of this bug. ***
Comment 8 Alexei Dets 2004-02-23 23:55:55 UTC
This bug is still present in kopete-0.8.0 from KDE-3.2 final (RPMs from kde-redhat.sf.net). Do you have any plans of immediate release of kopete-0.8.1?
kopete is unusable in its current form :-(((
Comment 9 Richard Smith 2004-02-24 00:15:02 UTC
Well, it works fine for me, and presumably for everyone else who tried it, since this would be a pretty obvious bug. Perhaps you could be more specific about the problem, or anything which might make your system be different to ours.
Comment 10 Matt Rogers 2004-02-24 00:16:08 UTC
There will be a release of KDE 3.2.1 (and Kopete 0.8.1 for KDE 3.1 users) sometime around the 1st week or two of March.
Comment 11 effco 2004-09-21 12:36:46 UTC
Could you reopen this bug ? or set it to "New" ? I have this problem with Kopete in Mandrake 10.1 Community. 

see http://qa.mandrakesoft.com/show_bug.cgi?id=8361 

if you open Kopete for the first time, you enter accounts parameters 
and passwords in the "Configuration window". 

Then if you do File-> Connect All, Kopete ask again for passwords even if they 
were correctly given in the configuration step 

versions installed : 
KDE 3.2.3 
libkdenetwork2-kopete-3.2.3-15mdk 
kdenetwork-kopete-3.2.3-15mdk

Thanks 

Fred
Comment 12 Matt Rogers 2004-09-21 14:34:13 UTC
no, we won't reopen the bug because it's already fixed in KDE 3.3. Please upgrade