Bug 71907

Summary:	KStars does not compile with --enable-final
Product:	[Applications] kstars	Reporter:	Dik Takken <kde>
Component:	general	Assignee:	kstars
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	compiler output

Description Dik Takken 2004-01-05 14:20:03 UTC

Version:            (using KDE KDE 3.1.94)
Installed from:    Compiled From Sources
Compiler:          gcc version 2.96 20000731 (Red Hat Linux 7.1 2.96-98) 
OS:          Linux

KStars won't compile with --enable-final on my Redhat 7.1 box, while the rest of KDE 3.2 Beta 2 compiles just fine. I have attached the output of the compiler.

Comment 1 Dik Takken 2004-01-05 14:20:34 UTC

Created attachment 3982 [details]
compiler output

Comment 2 kstars 2004-01-05 15:45:20 UTC

Subject: Re:  KStars does not compile with --enable-final

Yes, this is a known "issue".  See:
http://bugs.kde.org/show_bug.cgi?id=65429

Can it be considered a bug that we have marked KStars as "-nofinal"?  
I thought this was regarded as an acceptable workaround?

Jason

On Monday 05 January 2004 08:20 am, you wrote:
> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>
> http://bugs.kde.org/show_bug.cgi?id=71907
>            Summary: KStars does not compile with --enable-final
>            Product: kstars
>            Version: unspecified
>           Platform: Compiled Sources
>         OS/Version: Linux
>             Status: UNCONFIRMED
>           Severity: normal
>           Priority: NOR
>          Component: general
>         AssignedTo: kstars@30doradus.org
>         ReportedBy: takken@phys.uu.nl
>
>
> Version:            (using KDE KDE 3.1.94)
> Installed from:    Compiled From Sources
> Compiler:          gcc version 2.96 20000731 (Red Hat Linux 7.1
> 2.96-98) OS:          Linux
>
> KStars won't compile with --enable-final on my Redhat 7.1 box,
> while the rest of KDE 3.2 Beta 2 compiles just fine. I have
> attached the output of the compiler.

Comment 3 Dik Takken 2004-01-05 15:55:51 UTC

My opinion is that any app that is distributed with KDE should compile with --enable-final, out of the box. I always compile all of KDE with --enable-final and it is not very 'clean' if KStars is the only app that aborts because of the --enable-final flag.

Comment 4 Stephan Kulow 2004-01-06 13:25:42 UTC

misunderstanding. The nofinal option in there lets it build without the hack even if you specify --enable-final. It's fixed

Comment 5 Stephan Kulow 2004-01-06 13:25:53 UTC

*** Bug has been marked as fixed ***.