Bug 71866

Summary: conversion of pop filter settings dangerous
Product: [Unmaintained] kmail Reporter: Maik Schulz <list>
Component: generalAssignee: kdepim bugs <kdepim-bugs>
Status: RESOLVED FIXED    
Severity: critical    
Priority: NOR    
Version: 1.6   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: This fixes the bug

Description Maik Schulz 2004-01-05 00:00:47 UTC 
Version:           1.5.94 (using KDE 3.1.94 (3.2 Beta 2), SuSE)
Compiler:          gcc version 3.3 20030226 (prerelease) (SuSE Linux)
OS:          Linux (i686) release 2.4.23

In KMail from KDE 3.1.4 I had a filter to delay downloading of emails that exceed 50000 bytes (and to show the dialogue). After installing 3.2B2 the filter was set to delete those emails on the server!
Comment 1 Ingo Klöcker 2004-02-04 17:16:33 UTC 
Confirmed.
Comment 2 Ingo Klöcker 2004-02-04 17:29:57 UTC 
Created attachment 4511 [details]
This fixes the bug

That's a prime example for why it's bad to store the value of an enum as a
number in a config file. The reason for this bug is a reordering of the enum
values in the code. This changed the meaning of the value which is stored in
the config file.

With the patch KMail stores the enum as a string representing the enum value.
As a consequence all POP filters will be reset to NoAction. But there is no
other fix possible because it's impossible to find out whether the pop filter
configuration was saved with KMail 1.6 or with a previous version of KMail.
Comment 3 Ingo Klöcker 2004-02-05 11:09:10 UTC 
This bug has been fixed. The fix will be in KDE 3.2.1. Note that all POP filters will be reset to "Download later" because we now store the filter actions in a safe way in order to prevent further bugs caused by misinterpretations of values in the configuration file.
Comment 4 Carsten Pfeiffer 2004-02-05 11:27:19 UTC 
> But there is no other fix possible because it's impossible to find out 
> whether the pop filter configuration was saved with KMail 1.6 or with a 
> previous version of KMail.

I suggest adding a 'version' attribute to the config file.
Comment 5 Caio 2004-02-07 06:46:44 UTC 
It would like to know where place I apply patche: kdepim-3.2.0-HOT_FIX_FOR_KMAIL.patch which is the directory?  Remembering that I use Slackware 9.1
Comment 6 Caio 2004-02-07 20:03:38 UTC 
I installing the following packages: kdegraphics-3.2.0-i486-2.tgz - kdemultimedia-3.2.0-i486-2.tgz - kdepim-3.2.0-i486-2.tgz I solve this bug?