Bug 70937

Summary: Erroneous play queue flow control
Product: [Unmaintained] noatun Reporter: Benedikt Gollatz <benedikt>
Component: splitAssignee: Charles Samuels <charles>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Benedikt Gollatz 2003-12-20 21:57:36 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
Compiler:          gcc (GCC) 3.3.1 
OS:          Linux

Splitplaylist acts unexpected in a few cases.

First, when hitting "back" it jumps to the file above and plays it regardless of whether it isOn() or not. This can easily be corrected by adding three lines to playlist.cpp:

--- kdemultimedia/noatun/modules/splitplaylist/playlist.cpp	2003-11-16 21:42:37.000000000 +0100
+++ kdemultimedia/noatun/modules/splitplaylist/playlist.cpp	2003-12-20 21:44:41.000000000 +0100
@@ -144,4 +144,8 @@
 
 	setCurrent(nextItem);
+	
+	if (currentItem)
+		if (!static_cast<SafeListViewItem*>(currentItem.data())->isOn())
+			return previous();
 
 	return currentItem;

The problem with this is, that the playlist does not loop backwards.

Additionally, when leaving the last item of the playlist unchecked, Splitplaylist loops to the first checked file but plays the last (unchecked) file on the list.
Comment 1 Charles Samuels 2004-10-04 12:30:15 UTC
commited fix to this recently