Bug 70791

I've restored this feature yesterday. Please update.

I am rebuilt as of today, Saturday but I don't see any change in the tab after the file has been modified. I do see the undo/redo buttons change. What is the tab change supposed to look like? 

Which file is it implemented in so that I can check and make sure the change made it to the CVS mirrors. Sometimes the mirrors get broken and stop propogating.

kdevelop/src/mainwindow.cpp r.1.64
kdevelop/src/partcontroller.cpp r.1.110
kdevelop/src/partcontroller.h r.1.41

After you change the file, the "kdevelop" icon on the tab will be changed to "save file" icon.

The changes finally made it out to the CVS mirrors. It looks like the QT update bogged the copying process down alot. Don't know what the changes look like yet, I've been building for four hours and still not done.

Something is wrong with the check-in of partcontroller.cpp. It is only at version 1.109. Mainwindow.cpp is at 1.64 and partcontroller.h is at 1.41, those are the right versions.

I checked three CVS mirrors and they are all the same.

[jonsmirl@smirl src]$ cvs -z3 -d :pserver:anonymous@anoncvs.kde.org:/home/kde log partcontroller.cpp
 
RCS file: /home/kde/kdevelop/src/partcontroller.cpp,v
Working file: partcontroller.cpp
head: 1.109
branch:
locks: strict
access list:
keyword substitution: kv
total revisions: 111;   selected revisions: 111
description:

Oops, my bad ;) 1.109 is the correct revision.

Well if that's case, then I don't see any change when the file is edited.

I played around with this more. The icons are changing when the file gets modified but the change is not being displayed in ideal mode.

For example:
1) edit file in ideal mode
2) note no change in icon on tab
3) switch into top window mode, note file save icon is there
4) switch back into ideal mode.
5) tab has changed to filesave icon.

Another clue might be that the icons on the tabs in ideal mode and not the same as the icons used in top level window mode.

It works fine with HEAD and kde 3.1.3 QT 3.1.2

I think that if you use KDE 3.2 you need to recompile kdelibs.

Yes, this _should_ work now, with kdelibs-HEAD. Not backported to kdevelop local kmdi for KDE-3.1/3.0 yet.

Hello,

I have KDE 3.1 and Kdevelop 2004-01-05 and this isn't resolved.
So, for those that are in the same case (is this will be backported for KDE 3.1), I've done a small hack.
It's working for me in IDEAui mode (not tryed for others) :

369c369
<                 PartController::getInstance()->restorePartWidgetIcon(ro_part);
---
>                 ro_part->widget()->setIcon(0); //MOI: PartController::getInstance()->restorePartWidgetIcon(ro_part);
451,452c451,452
<     view->setIcon(SmallIcon("kdevelop"));
<     child->setIcon(SmallIcon("kdevelop")); // was empty or too big, take something useful
---
>     //MOI: view->setIcon(SmallIcon("kdevelop"));
>     //MOI: child->setIcon(SmallIcon("kdevelop")); // was empty or too big, take something useful
503c503
<         view->setIcon(SmallIcon("kdevelop")); // was empty or too big, take something useful
---
>         //MOI: view->setIcon(SmallIcon("kdevelop")); // was empty or too big, take something useful
535c535
<         view->setIcon(SmallIcon("kdevelop")); // was empty or too big, take something useful
---
>         //MOI: view->setIcon(SmallIcon("kdevelop")); // was empty or too big, take something useful


Sorry : I've used diff but it's a strange output :-/
No time to learn more.
In brief : comment all
  view->setIcon(SmallIcon("kdevelop"));
lines to not have the kdevelop icon and replace the first with
  ro_part->widget()->setIcon(0);
To reset icon when saved.