| Summary: | disable Folder->Properties action if no folder is selected | ||
|---|---|---|---|
| Product: | [Unmaintained] kmail | Reporter: | Laurent Montel <montel> |
| Component: | folder list | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | minor | CC: | kollix, lemma |
| Priority: | NOR | Keywords: | triaged |
| Version: | 1.10.3 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
Okay, I fixed the crash. The remaining issue is of minor importance. Sorry, I forgot to change the Summary. If no folder is selected, the folder->properties option is still available. It should be greyed out. Tested on KMail 1.10.1 (KDE 4.1.2) I can't reproduce this on trunk r887937. I'm however not quite sure if this applies to this bug because if I remove all folders KMail creates them anew. in 4.3 the folder are created, but none is selected - and the good thing: the folder properties menu is grayed out. |
Version: (using KDE Devel) Installed from: Compiled sources OS: Linux Hi, When we have a new unix account or we make "rm -rf .kde/ && rm -rf ~/Mail" and we launch kmail. There is not a item selected into tree folder. And we click on "folder->properties" kmail crash. Problem is the we don't disable action when there is not an item selected into kmail. I created a temporary patch. --- kdepim-3.1.94/kmail/kmmainwidget.cpp-- 2003-12-12 05:39:39.000000000 -0500 +++ kdepim-3.1.94/kmail/kmmainwidget.cpp 2003-12-12 05:39:53.000000000 -0500 @@ -814,7 +814,8 @@ void KMMainWidget::slotModifyFolder() { if (!mFolderTree) return; KMFolderTreeItem *item = static_cast<KMFolderTreeItem*>( mFolderTree->currentItem() ); - item->properties(); + if( item ) + item->properties(); } it fixes crash. But we must disable by default menu item when there is not a folder selected. Regards.