Bug 69492

Summary:	missing action/shortcut for separate reader window from search results
Product:	[Unmaintained] kmail	Reporter:	Martin Koller <kollix>
Component:	search	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED WORKSFORME
Severity:	wishlist	CC:	bluedzins, mmodem00, sven.burmeister, thiago
Priority:	NOR
Version:	1.5.94
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Adding action to open mail in separate window

Description Martin Koller 2003-12-02 10:19:02 UTC

Version:           1.5.94 (using KDE 3.1.94 (3.2 Beta 2), compiled sources)
Compiler:          gcc version 2.96 20000731 (Red Hat Linux 7.2 2.96-112.7.2)
OS:          Linux (i686) release 2.4.22

What I miss is the possibility to directly open a separate reader window from the search-result dialog.
So I tried to find the action "open mail in sep. window" to be able to assign a shortcut - but in no menu I could find it.

So I have 2 points:

1) I think for usability reasons there should be the possibility to not only open the sep.reader window with a double click, but also via a shortcut/toolbutton - so the action for it is missing.

2) In the search dialog (result list) there should be either also the behaviour, that a double click opens that sep.reader window, or this action should be in the RMB (where I prefer the double-click, which is then consistent with the message list).
Currently to view the details of a found mail, I have to double-click the found mail and at least move the dialog window away, which is not very user friendly.

Comment 1 Thiago Macieira 2004-02-26 22:57:44 UTC

Created attachment 4907 [details]
Adding action to open mail in separate window

Answering to request #1, I've got a patch. A friend asked me how to do that and
I couldn't find. Since I wanted him to keep using KMail, I thought I'd do him a
favour and create the action for him.

I've tested in my system and it works. I set it to Key_Enter, but it's
apparently KP_Enter.

Comment 2 Tom Albers 2004-07-31 01:10:32 UTC

*** Bug 85563 has been marked as a duplicate of this bug. ***

Comment 3 Zé 2004-08-12 23:39:35 UTC

I did applyed this patch and when i right click in a email (this in the search window) did not appeared any option "&Open Message" to open it.

Any help?

Comment 4 Thiago Macieira 2004-08-13 00:15:27 UTC

The patch doesn't create the action in the RMB menu.

Comment 5 Thiago Macieira 2005-02-13 03:25:27 UTC

This has been applied to HEAD (kmail 1.8-to-be).

Comment 6 S. Burmeister 2005-05-25 14:49:50 UTC

What does kmail 1.8-to-be mean? In 1.8 it is not possible to open a mail from the search reaults by double-clicking it. Which makes the search a bit senseless, as the search-window covers the headers-list, so the user does not see that the message one clicked on is focused. This is especially true for fullscreen search window.

Comment 7 Zé 2007-07-11 04:34:46 UTC

Why this still wasnt commited into branch_3.5, any special reason?

Comment 8 Zé 2007-07-11 05:26:37 UTC

i have applied this patch with kde from branch_3.5 svn release 686315 and it outputed severall error messages, but ill paste the starting errors:

/mmodem/rpm/BUILD/kdepim/ktnef -I/home/mmodem/rpm/BUILD/kdepim -I/home/mmodem/rpm/BUILD/kdepim/libkdepim -I/usr/lib/qt3//include -I/usr/include -DQT_THREAD_SUPPORT -D_REENTRANT -D_LARGE_FILES=1 -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -DNDEBUG -DNO_DEBUG -O2 -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -Wformat-security -Wmissing-format-attribute -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -fPIC -DPIC -c ./kmail/libkmailprivate_la_all_cpp.cpp -o ./kmail/.libs/libkmailprivate_la_all_cpp.o -Wp,-MD,./kmail/.deps/libkmailprivate_la_all_cpp.TUlo
./kmail/kmmainwidget.h:411: error: ‘void KMMainWidget::slotOpenMsg()’ cannot be overloaded
./kmail/kmmainwidget.h:301: error: with ‘void KMMainWidget::slotOpenMsg()’

Comment 9 Martin Koller 2007-07-11 12:19:33 UTC

Obviously this is not fixed (in kmail 1.9.7 - KDE 3.5.7)

Comment 10 Thiago Macieira 2007-07-11 16:27:00 UTC

Are you guys on crack? This has been in the KMail source code for well over two years now.

The patch I posted is obviously outdated. It does not apply. It is not MEANT to apply.

However, when rereading the original request, I have only new realised that it asked for the *search* window. My patch was never meant to do that. So this bug was actually never solved.

Comment 11 Martin Koller 2009-08-17 18:12:30 UTC

Both requests seem to work with KDE 4.3. closing