Bug 69207

Summary:	Dock icon is name not sane
Product:	[Applications] kget	Reporter:	Dan Leinir Turthra Jensen <leinir>
Component:	general	Assignee:	KGet bugs <kget-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	tyrerj
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Dan Leinir Turthra Jensen 2003-11-28 12:57:43 UTC

Version:            (using KDE KDE 3.1.93)
Installed from:    Compiled From Sources
OS:          Linux

Because the kget dock icon is simply named "dock" (situated in actions), the icon is not easily themed, because if other applications decide to use a more generic icon this name would be the first choice, and thus not available (for example, for a settings dialog, where there is a separate settings pane for the dock). I suggest naming the icon kget_dock or similar.

Comment 1 James Richard Tyrer 2004-08-26 01:30:05 UTC

I will also add that the current code doesn't appear to be able to theme this icon.  I added the old (KDE-3.2.3) icon as:

$KDEDIR/share/apps/kget/icons/kdeclassic/22x22/actions/dock.png

and although my selected theme is KDEClassic, it still shows the CrystalSVG icon. :-(

Also, I think that if the Drop Target is going to be CrystalSVG that it should also be themeable.

--
JRT

Comment 2 Pino Toscano 2005-06-04 15:42:11 UTC

SVN commit 422084 by pino:

Giving a better icon for the 'dock' icon, so it's easily themeable by our artists.

CCBUG: 69207



 M  +1 -1      docking.cpp  
 D             icons/cr22-action-dock.png  
 A             icons/cr22-action-kget_dock.png   icons/cr22-action-dock.png#422078


--- trunk/KDE/kdenetwork/kget/docking.cpp #422083:422084
@@ -42,7 +42,7 @@
 {
     parent = _parent;
 
-    setPixmap( loadIcon( "dock" ));
+    setPixmap( loadIcon( "kget_dock" ));
 
     // popup menu for right mouse button
     KPopupMenu *popupMenu = contextMenu();

Comment 3 Pino Toscano 2005-06-04 15:45:01 UTC

SVN commit 422087 by pino:

Giving a better icon for the 'dock' icon, so it's easily themeable by our artists. 

BUG: 69207



 M  +1 -1      docking.cpp  
 D             icons/cr22-action-dock.png  
 A             icons/cr22-action-kget_dock.png   icons/cr22-action-dock.png#421115


--- branches/KDE/3.4/kdenetwork/kget/docking.cpp #422086:422087
@@ -42,7 +42,7 @@
 {
     parent = _parent;
 
-    setPixmap( loadIcon( "dock" ));
+    setPixmap( loadIcon( "kget_dock" ));
 
     // popup menu for right mouse button
     KPopupMenu *popupMenu = contextMenu();