| Summary: | fish shows size of target file for symlinks | ||
|---|---|---|---|
| Product: | [Unmaintained] kio | Reporter: | dexter |
| Component: | fish | Assignee: | Jörg Walter <trouble> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | devriese |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
This bug has also been posted ( with the same patch ) to the Debian BTS: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=22230 I also confirmed it, the patch seems correct to me, but I haven't tested it. cheers domi That should've been http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=222304 Subject: yes Patch looks ok, please apply. Subject: kdebase/kioslave/fish CVS commit by domi: Apply patch from http://bugs.kde.org/show_bug.cgi?id=69158 Approved by David Faure. Will backport. CCMAIL:faure@kde.org CCMAIL:69158-done@bugs.kde.org M +1 -1 fish.pl 1.12 --- kdebase/kioslave/fish/fish.pl #1.11:1.12 @@ -166,5 +166,5 @@ foreach (@entries) { my $link = readlink; - my ($mode,$uid,$gid,$size,$mtime) = (stat)[2,4,5,7,9]; + my ($mode,$uid,$gid,$size,$mtime) = (lstat)[2,4,5,7,9]; print filetype($mode,$link,$uid,$gid); print "S$size\n"; |
Version: (using KDE Devel) Installed from: Compiled sources Fish shows the size of target file for symlinks. It causes that file manager wrong counts size of directory. If it is feature, not bug, then please provide some switch to restore original unix behaviour (i.e. fish://user@host:lstat/) Proposed patch: --- f 2003-11-27 13:50:25.000000000 +0100 +++ .fishsrv.pl 2003-11-27 14:08:28.000000000 +0100 @@ -3,7 +3,7 @@ chdir($dn) || do { print "### 500 $!\n"; next; }; foreach (@entries) { my $link = readlink; -my ($mode,$uid,$gid,$size,$mtime) = (stat)[2,4,5,7,9]; +my ($mode,$uid,$gid,$size,$mtime) = (lstat)[2,4,5,7,9]; print filetype($mode,$link,$uid,$gid); print "S$size\n"; print strftime("D%Y %m %d %H %M %S\n",localtime($mtime));