| Summary: | cddb submission via smtp does not work | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] libkcddb | Reporter: | Melchior Franz <mfranz> |
| Component: | general | Assignee: | Richard Lärkäng <larkang> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | larkang |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Patch to fix the problem
Patch to fix the problem |
||
|
Description
Melchior Franz
2003-11-24 01:10:26 UTC
This is was kiosmtp is telling me. So the server is refusing the authentication, which is OK. It is isn't set up to do authentication. The failure is in kscd/cddb: it must not try to force auth on the server. kio_smtp: Parsing request from query: to=freedb-submit@freedb.org subject=cddb%20misc%20f10fc112 from=mfranz@aon.at kio_smtp: S: 220 server.lan ESMTP Sendmail 8.12.7/8.12.7/SuSE Linux 0.6; Mon, 24 Nov 2003 00:44:20 +0100^M kio_smtp: C: <16 bytes> kio_smtp: S: 250-server.lan Hello localhost [127.0.0.1], pleased to meet you^M kio_smtp: S: 250-ENHANCEDSTATUSCODES^M kio_smtp: S: 250-PIPELINING^M kio_smtp: S: 250-8BITMIME^M kio_smtp: S: 250-SIZE^M kio_smtp: S: 250-DSN^M kio_smtp: S: 250-ETRN^M kio_smtp: S: 250-AUTH DIGEST-MD5 CRAM-MD5^M kio_smtp: S: 250-DELIVERBY^M kio_smtp: S: 250 HELP^M kio_smtp: parseFeatures() PLAIN AUTH METHODS: SASL/CRAM-MD5 SASL/DIGEST-MD5 kio_smtp:° kio_smtp: parseFeatures() PLAIN CAPABILITIES: 8BITMIME AUTH DIGEST-MD5 CRAM-MD5 DELIVERBY DSN ENHANCEDSTATUSCODES ETRN HELP PIPELINING SIZE kio_smtp:° kio_smtp: C: <17 bytes> kio_smtp: S: 334 bm9uY2U9IktPdkZxNkorcDFIL0FDSG9QeG9BTGlqZDR6dlVyYlA2bmxiWGpnSlk0MUE9IixyZWFsbT0ic2VydmVyLmxhbiIsc> kio_smtp: C: <282 bytes> kio_smtp: S: 535 5.7.0 authentication failed^M kio_smtp: closing connection Did I misunderstand you, or did you specify the username and password for login to your box? The username and password is used only if you need to authenticate to your SMTP server, which you say you don't need, so you should not set a username. > Did I misunderstand you, or did you specify the username > and password for login to your box? You understood correctly. :-) > The username and password is used only if you need to authenticate > to your SMTP server, which you say you don't need, so you should not > set a username. There wasn't anything like this mentioned anywhere. I looked into the kcmcddb help[1] and searched in kscd's documentation. But anyway: removing the username doesn't change anything. Still I'm asked for username and password. If I leave both empty as you suggest, then I still get the "Error sending message via SMTP\nUnknown error." Note that I write emails to localhost:25 with "mail", "mutt", "kmail", and even "telnet localhost 25". None of these has ever asked for authentication and refused to relay local emails to the internet. m. [1] This is all of the "help" in kcmcddb: "CDDB is used to get information like artist, title and song-names in CD's". Cool! ;-) Oh, looks like you're right, I must use authentication for my smtp-server, so I haven't tested without. I guessed that setting an empty username would be the same as not setting one at all would be the same, but looking at the code, it looks like that's not the case. I'll attach a simple patch that you can try out. Created attachment 3386 [details]
Patch to fix the problem
This should fix it, go to libkcddb subdirectory and apply.
Created attachment 3387 [details]
Patch to fix the problem
This should fix it, go to libkcddb subdirectory and apply.
Yes, this patch works. But how should a user know that he has to leave this field empty to make the cddb feature not fail miserably with a completely bogus error message? I know about string freeze, but I'd rather put an untranslated English explanation there, than frustrating the users. m. Subject: kdemultimedia/libkcddb CVS commit by larkang: Only set the username if it isn't empty. Fixes sending of cddb-information if smtp-server doesn't need authentication CCMAIL: 68906-done@bugs.kde.org M +2 -1 smtpsubmit.cpp 1.7 --- kdemultimedia/libkcddb/smtpsubmit.cpp #1.6:1.7 @@ -40,4 +40,5 @@ namespace KCDDB url_.setHost(hostname); url_.setPort(port); + if (!username.isEmpty()) url_.setUser(username); url_.setPath("/send"); Btw I guess it could be possible to change the text if we can find anything more clear, but I'm not completely sure. Do you have any suggestions on another text? Subject: Re:
> Btw I guess it could be possible to change the text if we can
> find anything more clear, but I'm not completely sure.
"Change the text"? There *is* no text right now, except from
the "Username:" label next to an empty input field. And people,
even computer savvy people, tend to fill out empty input fields.
It can IMHO only be done in the following way:
Server: ________________
[ ] Server needs authentication
Username: ________________
Whereby the Username field would be grayed out and only enabled if
the checkbox in "Server needs authentication" is checked.
m.
Subject: kdemultimedia/libkcddb/kcmcddb CVS commit by larkang: Make it more clear that the username should only be entered if it is needed by the smtp-server for sending mails. Won't be in KDE until 3.3 because of new string CCMAIL: 68906@bugs.kde.org M +144 -110 cddbconfigwidgetbase.ui 1.20 M +16 -2 kcmcddb.cpp 1.21 |