Bug 68870

Hi!

As more and more people use notebooks to do their daily work, resolutions like
 - 1400x1050
 - ...
might prove useful as well.

Can't we use some other list, like the one "Display Settings" -> "Screen Size" uses?

Simply introducing the new resolutions shouldn't be hard work I suppose (a few lines -> cvs)...

krdc supports custom sizes (and you can specify a default for all future connections). Are specific combinations really needed?

Can you please explain why specific combinations are required, when you can use custom settings?

Hi,
There is no real need to add specific combinations but as there are already some that are "old" and that nowadays screens tend to have a size of 1280x1024 or 1600x1200 i though it was a good idea to add them.
Thanks.

SVN commit 566998 by kling:

Added resolution options for 1280x1024 and 1600x200, and changed the resolution names to better reflect the times.

BUG: 68870


 M  +13 -3     rdpprefs.ui  
 M  +20 -2     rdpprefs.ui.h  


--- trunk/KDE/kdenetwork/krdc/rdp/rdpprefs.ui #566997:566998
@@ -50,21 +50,31 @@
                 <widget class="QComboBox" row="0" column="1" rowspan="1" colspan="4">
                     <item>
                         <property name="text">
-                            <string>Small (640x480)</string>
+                            <string>Minimal (640x480)</string>
                         </property>
                     </item>
                     <item>
                         <property name="text">
-                            <string>Medium (800x600)</string>
+                            <string>Small (800x600)</string>
                         </property>
                     </item>
                     <item>
                         <property name="text">
-                            <string>Big (1024x768)</string>
+                            <string>Normal (1024x768)</string>
                         </property>
                     </item>
                     <item>
                         <property name="text">
+                            <string>Large (1280x1024)</string>
+                        </property>
+                    </item>
+                    <item>
+                        <property name="text">
+                            <string>Very Large (1600x1200)</string>
+                        </property>
+                    </item>
+                    <item>
+                        <property name="text">
                             <string>Custom (...)</string>
                         </property>
                     </item>
--- trunk/KDE/kdenetwork/krdc/rdp/rdpprefs.ui.h #566997:566998
@@ -11,7 +11,7 @@
 void RdpPrefs::resolutionChanged( int selection )
 {
 #warning including ui.h
-  bool enable = (selection==3);
+  bool enable = (selection==5);
   spinWidth->setEnabled(enable);
   spinHeight->setEnabled(enable);
   widthLabel->setEnabled(enable);
@@ -35,6 +35,16 @@
       break;
 
     case 3:
+      spinWidth->setValue(1280);
+      spinHeight->setValue(1024);
+      break;
+
+    case 4:
+      spinWidth->setValue(1600);
+      spinHeight->setValue(1200);
+      break;
+
+    case 5:
     default:
       break;
   }
@@ -116,10 +126,18 @@
   {
     cmbResolution->setCurrentItem(2);
   }
-  else
+  else if (rdpWidth()==1280 && rdpHeight()==1024)
   {
     cmbResolution->setCurrentItem(3);
   }
+  else if (rdpWidth()==1600 && rdpHeight()==1200)
+  {
+    cmbResolution->setCurrentItem(4);
+  }
+  else
+  {
+    cmbResolution->setCurrentItem(5);
+  }
 }