| Summary: | isReachable() is not called when clicking on the contact icon | ||
|---|---|---|---|
| Product: | [Unmaintained] kopete | Reporter: | Matt Rogers <mattr> |
| Component: | Main Application | Assignee: | Kopete Developers <kopete-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | Fix isReachable mostly | ||
|
Description
Matt Rogers
2003-11-07 19:38:58 UTC
I Know i'ts a bug, but i like this feature^W^WBug personaly, i like to be ableto open chat window even for offline people. for some reason such as consulting quickly the history, or see if this people did not blocked me (MSN). And that makes clear: History has nothing to do inside a real chatwindow. Created attachment 3923 [details]
Fix isReachable mostly
Please review.
This fixes all cases of isReachable that I encountered during use. There's one
drag-and-drop issue not fixed, but I consider that not important enough for KDE
3.2 -- I even doubt many people will ever notice the bug there.
See the FIXME in KopeteContact.h for the 'real' fix post 3.2, but for now this
should do.
Note 1: The diff is -bBw to exclude whitespace changes for readability. Obvious
side effect is messed up indentation though :)
Note 2: The i18n strings are copied from the meta contact and thus legal to
add.
Martijn
I'm against the test in KopeteContact::execute() . I still want to be able to open chat window with offline msn contact for example. Sighor objected for the patch to forbeid to open a chat with myslef, i object now :-D Anyway all other FIXME and small code are fine. Subject: Re: [Kopete-devel] isReachable() is not called when clicking on the contact icon
On Friday 02 January 2004 10:55, Olivier Goffart wrote:
> I'm against the test in KopeteContact::execute() .
> I still want to be able to open chat window with offline msn contact for
> example.
For debugging it's indeed useful, but that's only for us developers. It is
really a bug for everyone else.
What about adding an extra option 'Force Start Chat' when compiling with
--enable-debug?
No, i use it in msn for example to know if the persone is realy offline (did not blocked me) and also to vew the few last messages in the history (even if i could use the real history window for that) Subject: Re: [Kopete-devel] isReachable() is not called when clicking on the contact icon
On Friday 02 January 2004 13:42, Olivier Goffart wrote:
> No, i use it in msn for example to know if the persone is realy
> offline (did not blocked me) and also to vew the few last messages in the
> history (even if i could use the real history window for that)
That sounds like two usability issues that should be solved differently to me.
Why can't you use the history plugin for that?
(What we could do is show the history automatically when clicking on a blocked
user, but that sounds a bit inconsistent to me. As for checking whether
someone blocked you, that could e.g. go into the contact info. It doesn't
belong here.)
Subject: kdenetwork/kopete/libkopete CVS commit by mklingens: Fix bug 67523 by calling isReachable even when clicking directly on a contact. Not suitable for backporting because some people (Hi Olivier :) abuse this feature for viewing recent history and to detect blocking status. With this only in HEAD it encourages them to find a proper solution. CCMAIL: 67523-done@bugs.kde.org M +22 -10 kopetecontact.cpp 1.166 M +4 -0 kopetecontact.h 1.120 M +10 -8 kopetemetacontact.cpp 1.198 > and to detect blocking status.
Euh, it seems microsoft™ fixed his server yesterday. Detecting if someone blocked us does not work anymore :-(
|