Bug 66404

Summary:	KListViewLineEdit::focusOutEvent does not call base class focusOutEvent
Product:	[Unmaintained] kdelibs	Reporter:	Kirill <bugs-kde-org>
Component:	general	Assignee:	Stephan Kulow <coolo>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Kirill 2003-10-22 17:57:28 UTC

Version:           current CVS (using KDE KDE 3.1.4)
Installed from:    Debian testing/unstable Packages
Compiler:          N/A N/A
OS:          Linux

+ KListView::focusOutEvent(ev);

Thanks.

Garbage added to circumvent idiotic validator. Garbage added to circumvent idiotic validator. Garbage added to circumvent idiotic validator. Garbage added to circumvent idiotic validator. Garbage added to circumvent idiotic validator. Garbage added to circumvent idiotic validator. Garbage added to circumvent idiotic validator. Garbage added to circumvent idiotic validator. Garbage added to circumvent idiotic validator. Garbage added to circumvent idiotic validator.

Comment 1 David Faure 2003-10-23 12:47:21 UTC

Subject: kdelibs/kdeui

CVS commit by faure: 

Applied patch from "Kirill": call base focusOutEvent. Except when we're going
to destroy the lineedit anyway.
This fixes the following bug: start renaming a bookmark in keditbookmarks,
activate another window -> the cursor keep blinking in keditbookmarks.
(Kirill: the idiotic validator would have been better circumvented with such a
description, of what the patch fixes :)
Thanks.
CCMAIL: 66404-done@bugs.kde.org, kde-code-devel@kde.org


  M +2 -0      klistview.cpp   1.210


--- kdelibs/kdeui/klistview.cpp  #1.209:1.210
@@ -380,4 +380,6 @@ void KListViewLineEdit::focusOutEvent(QF
     if (focusEv->reason() != QFocusEvent::Popup && focusEv->reason() != QFocusEvent::ActiveWindow)
         terminate(true);
+    else
+        KLineEdit::focusOutEvent(ev);
 }

Comment 2 Kirill 2003-10-24 01:08:30 UTC

I think it would hurt if base class was called in all cases, before destroying of course.

I didn't know this would fix an existing bug.

One way to improve the validator would be to make it give a warning rather than outright refuse to post the bug, saying that in its opinion the submission contains too little information and asking if the user would like to give more detail. But it should be optional imho.

By the way, I looked at a KListView X11 event log today, and I did not see any focus events for the KListViewLineEdit. I wonder how it ever gets Qt focus events...

Comment 3 Kirill 2003-10-24 01:09:12 UTC

I meant it would _not_ hurt, sorry.

Comment 4 Thiago Macieira 2003-10-24 02:27:46 UTC

You could have just typed a brief description, like "KListViewLineEdit does not call the parent class when it should. I noticed it because when I did X, it broke".