Bug 65320

Summary:	too easy to hit close button on tabs that have no title
Product:	[Applications] konqueror	Reporter:	Wilbert Berendsen <wbsoft>
Component:	tabbing	Assignee:	Konqueror Bugs <konqueror-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Wilbert Berendsen 2003-10-01 16:23:44 UTC

Version:           unknown (using KDE 3.1.92 (alpha2, CVS >= 20030921), compiled sources)
Compiler:          gcc version 3.2.1
OS:          Linux (i686) release 2.4.20-ck6

When tabs are loading in the background, initially they show the hostname as title. Then the title is cleared, and the tab becomes very small.

When you want to bring that tab to the foreground, one very easily closes the tab accidentally, because of it's small size. (And closing a tab can't be undone with ctrl-z).

Possible solution: never clear the tab title, until the html title is set in it.

Comment 1 Wilbert Berendsen 2003-10-01 17:17:01 UTC

forgot to say this only applies when having 'close buttons on tabs instead of 
website icons' enabled.

Comment 2 Stephan Binner 2003-10-12 20:07:32 UTC

Subject: kdebase/konqueror

CVS commit by binner: 

Ignore empty [in-between] captions like in KonqMainWindow::setCaption.
Not sure what the real solution for both and HTML pages without title is.
CCMAIL: 65320-done@bugs.kde.org


  M +2 -0      konq_view.cc   1.347


--- kdebase/konqueror/konq_view.cc  #1.346:1.347
@@ -612,4 +612,6 @@ void KonqView::setTabIcon( const  QStrin
 void KonqView::setCaption( const QString & caption )
 {
+  if (caption.isEmpty()) return;
+
   m_caption = caption;
   if (!m_bPassiveMode) frame()->setTitle( caption , 0L );