| Summary: | Tag guesser behavior for pattern matching | ||
|---|---|---|---|
| Product: | [Applications] juk | Reporter: | Konstantinos Georgokitsos <kgeorgokitsos> |
| Component: | general | Assignee: | Scott Wheeler <wheeler> |
| Status: | ASSIGNED --- | ||
| Severity: | wishlist | CC: | jfirebaugh, larkang |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Patch to improve tagguessing
Fix tagguessertest |
||
|
Description
Konstantinos Georgokitsos
2003-09-09 07:51:34 UTC
It will also happen when the name contains a ',' btw, isn't this more of a bug than a whishlist? Created attachment 2694 [details]
Patch to improve tagguessing
Here's a patch that I think will improve tagguessing.
First, it will strip the homedir out of the filename which it matches, this
isn't neccessary for fixing this bug, but without it the tests break, and I
think it makes sense anyway as I can't see why you would want to match
something with your homedir.
Also it strips the fileextension out of the end (only '.mp3' and '.ogg' now),
and makes it match all the way to the end of the path, because at least to me
it looks like you would always want that. That part could be improved by having
the extensions that are supported somewhere else and look those up.
And the most important change is that it will match any character except for an
'/' for everything except the tracknumber, so things like '.' and '(' can be
matched too (before it was only letters, numbers and whitespaces).
And it will skip the reading of regexps from the configfile, as it's not
possible to change with the gui, and I don't see the need for it either.
Also it will add some more patterns to match, as I found them on some of my
files, and I thought they were useful.
Of course, all of those changes doesn't need to be merged in, but at least to
me all of them makes sense.
And also, unless people agree that this is a bug, it will have to wait until
KDE 3.3
I will also attach some changes to the test-code, as it was broken atm.
This will still now work the way I want with files like: "Randy - Religion,
Religion (demo version)", as it would result in "Religion, religion" as track
name, and "demo version" as comment, where I would like "Religion, religion
(demo version)" as track name, but as I can fix this by removing all patterns
with '%c' in, that's good enough for me, and I definately can see why you would
want it to be like that.
Created attachment 2695 [details]
Fix tagguessertest
Patch to fix tagguessertest, and add another test with a ',' in.
Current JuK CVS version will accept "," and "." in the artist, album and title fields. By the way, it's a feature (not a bug) that "song title (remix)" gets parsed as title = "song title". That's because stuff at the end of the filename which appears in parentheses is treated as a comment (and in this case, having a comment "remix" makes sense to me). Maybe you could change that patch (haven't tested yet) to match any character that is not a separator in the pattern. e.g. for %a/%A/%T - %t it would match anything but / and -, while for %a/%A/[%T] - %t it would match anything but [, ] and /. I think this would make most patterns work as expected... *** Bug 70658 has been marked as a duplicate of this bug. *** I have albums with "!" in their name, which is not matched with a pattern like: %a - %A/%T %t That is to say, the pattern doesn't seem to match at all. This is vaguely irritating. |