Summary: | [test case] text-indent in Hebrew HTML pages moves right instead of left | ||
---|---|---|---|
Product: | [Applications] konqueror | Reporter: | giantsloth |
Component: | khtml renderer | Assignee: | Konqueror Developers <konq-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | xslf |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Debian testing | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | attaching testcase |
Description
giantsloth
2003-08-28 04:44:19 UTC
The suggested fix compiles in KDE 3.2.3, and it fixes the problem. I don't have a suitable machine for compiling CVS on, but anyway, here is an untested diff against CVS HEAD. It's probably not the right format as I don't have a local CVS copy. Any chance to see this fixed in KDE 3.3? --- kdelibs/khtml/rendering/render_block.cpp 2004-07-08 15:22:13.000000000 +0300 +++ render_block.cpp 2004-07-08 15:23:56.000000000 +0300 @@ -1505,9 +1505,9 @@ if (applyTextIndent && m_firstLine && style()->direction() == RTL ) { int cw=0; if (style()->textIndent().isPercent()) cw = containingBlock()->contentWidth(); - right += style()->textIndent().minWidth(cw); + right -= style()->textIndent().minWidth(cw); } //kdDebug( 6040 ) << "rightOffset(" << y << ") = " << right << endl; return right; Created attachment 8011 [details]
attaching testcase
patch looks right, sorry for the late review.
CVS commit by ggarand: Applying patch from giantsloth at fastmail.fm Inverted logic for text-indent in RTL BUG:63351 M +1 -1 render_block.cpp 1.51 --- kdelibs/khtml/rendering/render_block.cpp #1.50:1.51 @@ -1602,5 +1602,5 @@ RenderBlock::rightRelOffset(int y, int f if (style()->textIndent().isPercent()) cw = containingBlock()->contentWidth(); - right += style()->textIndent().minWidth(cw); + right -= style()->textIndent().minWidth(cw); } |